Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org, dgc@kernel.org
Subject: Re: improve log context annotations
Date: Tue, 21 Jul 2026 17:01:42 +0200	[thread overview]
Message-ID: <20260721150142.GA14984@lst.de> (raw)
In-Reply-To: <al84nDC0BvHr33Kz@nidhogg.toxiclabs.cc>

On Tue, Jul 21, 2026 at 11:16:40AM +0200, Carlos Maiolino wrote:
> Thanks. Those all look good for me. But I'm adding Dave to the thread as
> he has much more expertise with lockdep than me and I'd appreciate his
> input.

More review is always good.  But as a reminder for the audience:
lockdep and the lock context annotations are two totally seaprate
things.  The former verifies the locking state at runtime, while
the latter is about compile-time enforcement for the cases where
that is possible.


  reply	other threads:[~2026-07-21 15:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20  9:45 improve log context annotations Christoph Hellwig
2026-07-20  9:45 ` [PATCH 1/8] xfs: fix the lock annotation on xfs_iget_cache_hit Christoph Hellwig
2026-07-20  9:45 ` [PATCH 2/8] xfs: fix the lock annotation in xfs_extent_busy_update_extent Christoph Hellwig
2026-07-20  9:45 ` [PATCH 3/8] xfs: fix the lock annotation in xfs_mru_cache_lookup Christoph Hellwig
2026-07-20  9:45 ` [PATCH 4/8] xfs: improve lock annotations in the log code Christoph Hellwig
2026-07-20  9:45 ` [PATCH 5/8] xfs: add lock annotations to xfs_try_open_zone Christoph Hellwig
2026-07-20  9:45 ` [PATCH 6/8] xfs: add lock annotations to xlog_state_shutdown_callbacks Christoph Hellwig
2026-07-20  9:45 ` [PATCH 7/8] xfs: add a lock annotation to xlog_cil_push_background Christoph Hellwig
2026-07-20  9:45 ` [PATCH 8/8] xfs: add lock annotations to xfs_ail_delete* Christoph Hellwig
2026-07-21  9:16 ` improve log context annotations Carlos Maiolino
2026-07-21 15:01   ` Christoph Hellwig [this message]
2026-07-21 15:23     ` Darrick J. Wong
2026-07-21 15:27       ` Christoph Hellwig
2026-07-22  0:08   ` Dave Chinner
2026-07-22  9:20     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721150142.GA14984@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=dgc@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox