From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6878C42FCB2 for ; Mon, 27 Jul 2026 21:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785187509; cv=none; b=s3EpodhcehdgAdcTYyvrvl2OrauLwfSmUxTX98aOSJEzrMkBKG9QBWs7lz5JGAaTB0zbTucKxUynUSR1HuN5ev7m6efIwUysOk273ItoS0KiUZnV8rbAgd0FPH9ikHYPSRGwlt0lijvJR8YTSl8yUqAY4kMPiDf0F11v8iCUGdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785187509; c=relaxed/simple; bh=IoTbFOZjAyf7avwQh5L6KlSkgZ9QuRnmk0lJu3wGpgQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RE3qT7y5A3ztN72pK1K7YXE/MFxxjgNcU9TWBoHuMK8jwB0nu6DH5/6jKe6tRsCKGln5qku5gAK6aqAQFslWVS6+LpzYm2qKIhDmwvzeo9WYHy3P9Uxi7u3HqXBHFkqU+VHte4phLl+atX6L3NNzKA6fq5BUNlMGofo6TP2t89I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nhkxn36a; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nhkxn36a" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cce6a0c9c3so36840255ad.1 for ; Mon, 27 Jul 2026 14:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785187508; x=1785792308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k2+CmEJHSj+FxiNl193sQhU8qb1CcNkL+80ICC9UFKY=; b=nhkxn36awlXKJT/9A269oVcVrZzLYZLOFaG99l+EWdCzU/XFxDWZNblcnbfcuQnEPW 2wMMc0y8yByldPI5gxUJFv2jjRX3pEk/0H0+KL3WEEnjn/Kpnz0g7XQOi5i1MPrwme0q 1VKTW43/5/SfZGZYC/zGPX9PCFn8rnfJc73fKERZW6B0XtfF/LDBZN/HsvA44tHsO7Ab OELO+Dz1A2tEqLJhGAIH1RRvxX4hlg7NVg5NspGEsrUtb2az5+MKeIkhlRfiO0/39weF Aj6bI2lkx4+SZy6gjR+EbMPKsFxhs8/uVQwnhZC2nrOv9vKHA4Xy3hVHYh3uYXVKMBe1 Uzkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785187508; x=1785792308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=k2+CmEJHSj+FxiNl193sQhU8qb1CcNkL+80ICC9UFKY=; b=cYtA4jE5DhMniQ3Y5YfzjPUhepIHoLJnAfP8gqXc+jXAkgi+cca9kOlRY0dmlaUito cPjp2qb2y0QDrr21XSwm0IkEm4GEmEBc76ZjGDY38nCf+6jNd93T0xL/qV87FVynrkXE r6tBrU4jVbUbU30mrUK/AbH8AoK7MaSVh4Buq8G7gbwhY3y3t0eqJKIu+RdS5pfxMGeB Q3qKnsEggL28XpDdp1Y9vG0lhE+UWtn5te61PjqKsuJu8rCiIZyXhLTm9S5vTQBYNLvz +fe9HRsW4xFOBhjH/N3hvWgzRny/mYBA0zLqL4J9gidI0H37uttodYjN2YzDW7u+xSUy bc3w== X-Forwarded-Encrypted: i=1; AHgh+RoG/cIgvQgWJahLh5gkR47XHt8fT8a4GCsr3YZjwOLJyisqCVEJMrqz6dzkkHnPIivYsSb591o16QU=@vger.kernel.org X-Gm-Message-State: AOJu0YxBQneCMytQGK9pJcEFlqKpa0tYr5+6d/0F/DHIclT4QwQA0V6M IJOBGM5e+kqjixTHmGDjEYD1WgCgrjOGWuwl/vyUCFjk/nUc9wpPCXvs X-Gm-Gg: AR+sD11En6ToduDzBu88vOW1n9u+hxFSGvucjYJF79wNmtPhKc75T1deCm2F4SkovbH 7wJOXye5SzCyXyRpX9khBJZwG/XGTSaGrF4hhPfS8EshlC5ul4OrGAN58h/ZY5NdajN9KWZ8AXF 7KfsL0JPPk+cuIhz8Aq8zUV8Kvqy7p2OUTt7bIQTaBhHegulQju7c0yoBzeZLS8quZYHooPp8WI FXHQaITiXh/xCOGbM3UlPMcAnFiN/o6V/xK+jnEaUy7YmK6Vcs8hAeUFM6BS+6QIUcEFDoskC4d joA1FaxracSjq5isjbwvXCGV4i+xT+wmxhEU/zld+rlYDLjDk/fCGEzJ485B4afheYiVQtcGEgm a6CN74Ac2Gz7GBSvVfEVk/LXMbvp/+3RXNDCtBDqQtuN7hxbMppQxZOJniivzc6b2oN5dUFlPlQ Akb8kwojC28nEekRcm1M0O7tQHm5e56SOzbcG0Q0zvwoiGSpmxJ4GuN+eMqnQNluhb X-Received: by 2002:a17:902:e843:b0:2cc:7e4a:bcc5 with SMTP id d9443c01a7336-2d00f3e00fbmr8963385ad.32.1785187507779; Mon, 27 Jul 2026 14:25:07 -0700 (PDT) Received: from localhost ([2a03:2880:ff:50::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5c7678sm41171065ad.18.2026.07.27.14.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 14:25:07 -0700 (PDT) From: Joanne Koong To: Christian Brauner , hch@lst.de, "Darrick J . Wong" , linux-fsdevel@vger.kernel.org Cc: changfengnan@bytedance.com, kbusch@kernel.org, Matthew Wilcox , Jan Kara , Jonathan Corbet , David Sterba , Gao Xiang , Namjae Jeon , tytso@mit.edu, Jaegeuk Kim , Miklos Szeredi , Andreas Gruenbacher , Mikulas Patocka , Hyunchul Lee , Konstantin Komarov , Carlos Maiolino , Damien Le Moal , libaokun@linux.alibaba.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: [PATCH v4 19/21] iomap: remove ->iomap_begin()/->iomap_end() legacy path Date: Mon, 27 Jul 2026 14:17:56 -0700 Message-ID: <20260727211758.1116539-20-joannelkoong@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260727211758.1116539-1-joannelkoong@gmail.com> References: <20260727211758.1116539-1-joannelkoong@gmail.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With all in-tree filesystems implementing ->iomap_next(), drop the ->iomap_begin()/->iomap_end() path. Reviewed-by: Fengnan Chang Reviewed-by: Christoph Hellwig Reviewed-by: "Darrick J. Wong" Signed-off-by: Joanne Koong --- fs/iomap/iter.c | 6 +----- include/linux/iomap.h | 6 ++---- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c index e05574602946..f7c4d5cf56be 100644 --- a/fs/iomap/iter.c +++ b/fs/iomap/iter.c @@ -107,11 +107,7 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops) trace_iomap_iter(iter, ops, _RET_IP_); - if (ops->iomap_next) - ret = ops->iomap_next(iter, &iter->iomap, &iter->srcmap); - else - ret = iomap_iter_next(iter, &iter->iomap, &iter->srcmap, - ops->iomap_begin, ops->iomap_end); + ret = ops->iomap_next(iter, &iter->iomap, &iter->srcmap); iter->status = 0; if (ret > 0) diff --git a/include/linux/iomap.h b/include/linux/iomap.h index d203d9fe0f89..0bc1beb47a09 100644 --- a/include/linux/iomap.h +++ b/include/linux/iomap.h @@ -195,7 +195,7 @@ struct iomap_write_ops { }; /* - * Flags for iomap_begin / iomap_end. No flag implies a read. + * Flags for iomap_next. No flag implies a read. */ #define IOMAP_WRITE (1 << 0) /* writing, must allocate blocks */ #define IOMAP_ZERO (1 << 1) /* zeroing operation, may skip holes */ @@ -240,8 +240,6 @@ typedef int (*iomap_iter_next_fn)(const struct iomap_iter *iter, struct iomap *iomap, struct iomap *srcmap); struct iomap_ops { - iomap_iter_begin_fn iomap_begin; - iomap_iter_end_fn iomap_end; iomap_iter_next_fn iomap_next; }; @@ -256,7 +254,7 @@ struct iomap_ops { * incremental iter advance. * @status: Status of the most recent iteration. Zero on success or a negative * errno on error. - * @flags: Zero or more of the iomap_begin flags above. + * @flags: Zero or more of the iomap_next flags above. * @iomap: Map describing the I/O iteration * @srcmap: Source map for COW operations */ -- 2.52.0