From: Christoph Hellwig <hch@lst.de>
To: Anuj Gupta/Anuj Gupta <anuj20.g@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Carlos Maiolino <cem@kernel.org>,
Tal Zussman <tz2294@columbia.edu>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 20/22] xfs: add support for lazy direct read bounce buffering
Date: Tue, 28 Jul 2026 06:58:44 +0200 [thread overview]
Message-ID: <20260728045844.GA20331@lst.de> (raw)
In-Reply-To: <65cd47a4-eef5-43c5-a336-0a5693e5e4f1@samsung.com>
On Mon, Jul 27, 2026 at 07:44:32PM +0530, Anuj Gupta/Anuj Gupta wrote:
> On 7/23/2026 8:19 PM, Christoph Hellwig wrote:
> > +static ssize_t
> > +read_bounce_store(
> > + struct kobject *kobj,
> > + const char *buf,
> > + size_t count)
> > +{
> > + struct xfs_mount *mp = csum_to_mp(kobj);
> > +
> > + if (!strcmp(buf, "never"))
> > + WRITE_ONCE(mp->m_read_bounce, XFS_READ_BOUNCE_NEVER);
> > + else if (!strcmp(buf, "always"))
> > + WRITE_ONCE(mp->m_read_bounce, XFS_READ_BOUNCE_ALWAYS);
> > + else if (!strcmp(buf, "lazy"))
> > + WRITE_ONCE(mp->m_read_bounce, XFS_READ_BOUNCE_LAZY);
> it returns a -EINVAL always.
>
> # echo always > /sys/fs/xfs/nvme0n1/csum/read_bounce
> bash: echo: write error: Invalid argument
Use echo -n.
>
> Maybe use sysfs_streq here?
I've already switched this to table matching in the current version.
next prev parent reply other threads:[~2026-07-28 4:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 14:49 lazy bounce buffering for checksummed reads Christoph Hellwig
2026-07-23 14:49 ` [PATCH 01/22] iomap: add a separate bio_set for iomap_split_ioend Christoph Hellwig
2026-07-23 16:49 ` Darrick J. Wong
2026-07-24 6:22 ` Christoph Hellwig
2026-07-23 14:49 ` [PATCH 02/22] block: remove bip_should_check Christoph Hellwig
2026-07-23 14:49 ` [PATCH 03/22] block: lift BIP_CHECK_FLAGS to include/linux/bio-integrity.h Christoph Hellwig
2026-07-23 14:49 ` [PATCH 04/22] block: handle nogenerate/noverify properly in fs-integrity Christoph Hellwig
2026-07-23 17:05 ` Anuj gupta
2026-07-23 14:49 ` [PATCH 05/22] iomap: don't free integrity payload that doesn't exist Christoph Hellwig
2026-07-23 16:55 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 06/22] block,iomap: fix protection information verification with initial bvec offset Christoph Hellwig
2026-07-23 14:49 ` [PATCH 07/22] block: add task-context bio completion infrastructure Christoph Hellwig
2026-07-23 14:49 ` [PATCH 08/22] block: don't delay bio task completions Christoph Hellwig
2026-07-23 14:49 ` [PATCH 09/22] block: split bio_iov_iter_bounce_write Christoph Hellwig
2026-07-23 14:49 ` [PATCH 10/22] block: export fs_bio_integrity_{alloc,free} Christoph Hellwig
2026-07-23 14:49 ` [PATCH 11/22] block: don't include blk-integrity.h in bdev.c Christoph Hellwig
2026-07-23 14:49 ` [PATCH 12/22] iomap: better read bounce buffering support Christoph Hellwig
2026-07-23 21:10 ` Darrick J. Wong
2026-07-24 6:26 ` Christoph Hellwig
2026-07-27 14:17 ` Anuj Gupta/Anuj Gupta
2026-07-28 4:59 ` Christoph Hellwig
2026-07-23 14:49 ` [PATCH 13/22] iomap: add a iomap_ioend_flags helper Christoph Hellwig
2026-07-23 20:52 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 14/22] iomap: add a IOMAP_IOEND_INTEGRITY flag Christoph Hellwig
2026-07-23 20:53 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 15/22] iomap,xfs: move T10 PI handling for direct I/O into ->submit_io Christoph Hellwig
2026-07-23 20:55 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 16/22] xfs: move PI generation into xfs_zone_alloc_and_submit Christoph Hellwig
2026-07-23 20:55 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 17/22] xfs: split ioend handling into a separate source file Christoph Hellwig
2026-07-23 20:55 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 18/22] xfs: use BIO_COMPLETE_IN_TASK for bounce buffered read I/Os Christoph Hellwig
2026-07-23 15:58 ` Andrey Albershteyn
2026-07-24 6:21 ` Christoph Hellwig
2026-07-24 9:38 ` Andrey Albershteyn
2026-07-24 12:54 ` Christoph Hellwig
2026-07-23 20:58 ` Darrick J. Wong
2026-07-24 6:21 ` Christoph Hellwig
2026-07-23 14:49 ` [PATCH 19/22] iomap,xfs: move integrity verification to the file system Christoph Hellwig
2026-07-23 21:02 ` Darrick J. Wong
2026-07-24 6:23 ` Christoph Hellwig
2026-07-23 14:49 ` [PATCH 20/22] xfs: add support for lazy direct read bounce buffering Christoph Hellwig
2026-07-23 21:05 ` Darrick J. Wong
2026-07-24 6:24 ` Christoph Hellwig
2026-07-24 6:33 ` Christoph Hellwig
2026-07-27 14:14 ` Anuj Gupta/Anuj Gupta
2026-07-28 4:58 ` Christoph Hellwig [this message]
2026-07-23 14:49 ` [PATCH 21/22] xfs: add error injection for lazy " Christoph Hellwig
2026-07-23 21:06 ` Darrick J. Wong
2026-07-23 14:49 ` [PATCH 22/22] xfs: log a message at mount time when using integrity protection Christoph Hellwig
2026-07-23 21:07 ` Darrick J. Wong
2026-07-24 6:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728045844.GA20331@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox