From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, cem@kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs: don't leak dqacct if rhashtable insertion fails
Date: Thu, 30 Jul 2026 10:20:08 +0200 [thread overview]
Message-ID: <20260730082008.GD10558@lst.de> (raw)
In-Reply-To: <178538912965.4070956.18121841188530798974.stgit@frogsfrogsfrogs>
On Wed, Jul 29, 2026 at 10:27:04PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM observes that xqcheck_mod_live_ino_dqtrx doesn't free the newly
> allocated dqa object if rhashtable insertion fails. Fix this leak.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-07-30 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:26 [PATCHSET] xfs: LLM-inspired bug fixes, part 5 Darrick J. Wong
2026-07-30 5:26 ` [PATCH 1/6] xfs: fix unit conversions in per_binval computation Darrick J. Wong
2026-07-30 8:18 ` Christoph Hellwig
2026-07-30 5:26 ` [PATCH 2/6] xfs: fix short ifork reaping computation in xreap_bmapi_binval Darrick J. Wong
2026-07-30 8:19 ` Christoph Hellwig
2026-07-30 5:26 ` [PATCH 3/6] xfs: fix name string recording in slowpath pptr tracepoints Darrick J. Wong
2026-07-30 8:19 ` Christoph Hellwig
2026-07-30 5:27 ` [PATCH 4/6] xfs: don't leak dqacct if rhashtable insertion fails Darrick J. Wong
2026-07-30 8:20 ` Christoph Hellwig [this message]
2026-07-30 5:27 ` [PATCH 5/6] xfs: adjust datadev sector count to reflect internal rt volumes Darrick J. Wong
2026-07-30 8:22 ` Christoph Hellwig
2026-07-30 5:27 ` [PATCH 6/6] xfs: fix the rtrmap and rtrefcount _maxlevels_ondisk functions Darrick J. Wong
2026-07-30 8:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730082008.GD10558@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox