From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
Wilfred Mallawa <wilfred.mallawa@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] xfs: fix zoned write iomap flags assignments
Date: Mon, 10 Aug 2026 19:16:32 +0200 [thread overview]
Message-ID: <20260810171632.GA26992@lst.de> (raw)
In-Reply-To: <ann7HKGV6GgnzDQT@aalbersh-thinkpadx1carbongen13.rmtcz.csb>
On Mon, Aug 10, 2026 at 06:25:47PM +0200, Andrey Albershteyn wrote:
> > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> > index c80f05507373..9506cd8d15e6 100644
> > --- a/fs/xfs/xfs_aops.c
> > +++ b/fs/xfs/xfs_aops.c
> > @@ -634,11 +634,10 @@ xfs_zoned_map_blocks(
> > xfs_iunlock(ip, XFS_ILOCK_EXCL);
> >
> > wpc->iomap.type = IOMAP_MAPPED;
> > - wpc->iomap.flags = IOMAP_F_DIRTY;
> > wpc->iomap.bdev = mp->m_rtdev_targp->bt_bdev;
> > wpc->iomap.offset = offset;
> > wpc->iomap.length = XFS_FSB_TO_B(mp, count_fsb);
> > - wpc->iomap.flags = IOMAP_F_ANON_WRITE;
> > + wpc->iomap.flags = IOMAP_F_ANON_WRITE | IOMAP_F_DIRTY;
>
> Does it make sense to set IOMAP_F_DIRTY here? I haven't found how it
> could be used
Well, by the protocol of the flag we should set it as the update
requires a transaction to be persisted. But you are right in the
sense that nothing actually looks at it for zoned right now.
next prev parent reply other threads:[~2026-08-10 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 15:37 zoned xfs updates Christoph Hellwig
2026-08-10 15:37 ` [PATCH 1/5] xfs: handle NULL open_zone for merged ioends in xfs_ioend_put_open_zones Christoph Hellwig
2026-08-10 18:09 ` Darrick J. Wong
2026-08-10 15:37 ` [PATCH 2/5] xfs: fix racy open zone caching Christoph Hellwig
2026-08-10 18:21 ` Darrick J. Wong
2026-08-10 15:37 ` [PATCH 3/5] xfs: fix zoned write iomap flags assignments Christoph Hellwig
2026-08-10 16:25 ` Andrey Albershteyn
2026-08-10 17:16 ` Christoph Hellwig [this message]
2026-08-10 18:11 ` Darrick J. Wong
2026-08-10 15:37 ` [PATCH 4/5] xfs: factor out a xfs_iomap_set_anon_write helper Christoph Hellwig
2026-08-10 18:13 ` Darrick J. Wong
2026-08-10 15:37 ` [PATCH 5/5] xfs: split ioend handling into a separate source file Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810171632.GA26992@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
--cc=wilfred.mallawa@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox