Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: zlang@kernel.org, djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] generic/730: don't override $SCRATCH_DEV
Date: Fri, 21 Aug 2026 07:14:35 +0200	[thread overview]
Message-ID: <20260821051435.1818249-1-hch@lst.de> (raw)

generic/730 operates on a scsi_debug device, but overrides SCRATCH_DEV
to test for shutdown support.  Switch this to test the shutdown support
on the actual scratch device without overriding it, as shutdown support
should not depend on the actual device, and this ensures that options
that might not work on the scsi_debug device don't get applied to it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/730 | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/tests/generic/730 b/tests/generic/730
index 1798afb7deea..64d10bba73db 100755
--- a/tests/generic/730
+++ b/tests/generic/730
@@ -25,14 +25,17 @@ _cleanup()
 _require_test
 _require_block_device $TEST_DEV
 _require_scsi_debug
-# scsi_debug doesn't support DAX, so skip this test if MOUNT_OPTIONS
-# contains "dax"
-_exclude_scratch_mount_option "dax"
+
+# The actual test does not use the scratch device, but _require_scratch_shutdown
+# is the most sensible way to check that a file system supports shutdown.
+# Require scratch to use that check, but otherwise just use the scsi_debug
+# device.
+_require_scratch_nocheck
+_require_scratch_shutdown
 
 size=$(_small_fs_size_mb 256)
 SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size`
 test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device"
-SCRATCH_DEV=$SCSI_DEBUG_DEV _require_scratch_shutdown
 echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full
 
 run_check _mkfs_dev $SCSI_DEBUG_DEV
-- 
2.53.0


             reply	other threads:[~2026-08-21  5:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  5:14 Christoph Hellwig [this message]
2026-08-21 23:39 ` [PATCH] generic/730: don't override $SCRATCH_DEV Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821051435.1818249-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox