From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/073: destroy loop device when mount fails
Date: Fri, 21 Aug 2026 08:40:13 -0700 [thread overview]
Message-ID: <20260821154013.GK6072@frogsfrogsfrogs> (raw)
In-Reply-To: <20260821051424.1818198-1-hch@lst.de>
On Fri, Aug 21, 2026 at 07:14:24AM +0200, Christoph Hellwig wrote:
> Otherwise the failure will leave a dangling loop device around and
> prevent unmounting of $TEST_DIR and thus various cascading later
> failures.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Yeah, we should pull down the loopdev if we're bailing out.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> tests/xfs/073 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/073 b/tests/xfs/073
> index 2274079ef43b..057d1447639a 100755
> --- a/tests/xfs/073
> +++ b/tests/xfs/073
> @@ -74,6 +74,7 @@ _verify_copy()
> _mount -o nouuid $loop_dev1 $target_dir
> if [ $? -ne 0 ]; then
> echo mount failed - evil!
> + _destroy_loop_device $loop_dev1
> return
> fi
> fi
> --
> 2.53.0
>
>
prev parent reply other threads:[~2026-08-21 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:14 [PATCH] xfs/073: destroy loop device when mount fails Christoph Hellwig
2026-08-21 15:40 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821154013.GK6072@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox