From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs: fix parent rec lookup initialization in xrep_metapath_unlink
Date: Tue, 25 Aug 2026 11:14:40 -0700 [thread overview]
Message-ID: <20260825181440.GU6072@frogsfrogsfrogs> (raw)
In-Reply-To: <20260825063101.GD24324@lst.de>
On Tue, Aug 25, 2026 at 08:31:01AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 24, 2026 at 10:35:26PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > LOLLM notices that xrep_metapath_unlink looks for a parent pointer in
> > the child metafile that it's removing, but initializes the parent handle
> > using the child. This is obviously incorrect, so fix that.
>
> Eww. Can we come up with a reproducer for this?
At the moment it would be rather difficult to do that because all the
metadir directory tree paths have to be working correctly for the
filesystem to mount. I'll see if there's some evil way to do that,
like ... zeroing qflags, corrupting /quotas, and trying to truncate the
(unused) quota files while quota is offline.
> The fix looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks!
--D
next prev parent reply other threads:[~2026-08-25 18:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 5:34 [PATCHSET 1/2] xfs: LLM-inspired bug fixes, part 7 Darrick J. Wong
2026-08-25 5:34 ` [PATCH 1/6] xfs: don't spin forever on zero-length dirents when salvaging them Darrick J. Wong
2026-08-25 6:26 ` Christoph Hellwig
2026-08-25 18:11 ` Darrick J. Wong
2026-08-25 5:34 ` [PATCH 2/6] xfs: don't stash removename operations with unknown ftype Darrick J. Wong
2026-08-25 6:28 ` Christoph Hellwig
2026-08-25 18:12 ` Darrick J. Wong
2026-08-25 5:35 ` [PATCH 3/6] xfs: log the tempip after we convert it to extents format Darrick J. Wong
2026-08-25 6:28 ` Christoph Hellwig
2026-08-25 5:35 ` [PATCH 4/6] xfs: fix parent rec lookup initialization in xrep_metapath_unlink Darrick J. Wong
2026-08-25 6:31 ` Christoph Hellwig
2026-08-25 18:14 ` Darrick J. Wong [this message]
2026-08-25 5:35 ` [PATCH 5/6] xfs: handle reconnecting metadir subdirectories Darrick J. Wong
2026-08-25 6:32 ` Christoph Hellwig
2026-08-25 23:40 ` Darrick J. Wong
2026-08-26 4:46 ` Christoph Hellwig
2026-08-26 4:53 ` Darrick J. Wong
2026-08-25 5:35 ` [PATCH 6/6] xfs: lock the healthmon when inserting unmount event Darrick J. Wong
2026-08-25 6:33 ` Christoph Hellwig
2026-08-25 18:17 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2026-08-27 5:30 [PATCHSET v2 1/2] xfs: LLM-inspired bug fixes, part 7 Darrick J. Wong
2026-08-27 5:31 ` [PATCH 4/6] xfs: fix parent rec lookup initialization in xrep_metapath_unlink Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825181440.GU6072@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox