From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
Hans.Holmberg@wdc.com
Subject: [PATCH] xfs/837: set rtinherit on the root directory programmatically
Date: Wed, 26 Aug 2026 11:30:01 -0700 [thread overview]
Message-ID: <20260826183001.GV839663@frogsfrogsfrogs> (raw)
From: Darrick J. Wong <djwong@kernel.org>
I patched mkfs to enable metadir by default, but then this test
regressed on the "-m metadir=0 -d rtinherit=1..." configuration. Upon
digging into the test results, I observed that the scratch filesystem
actually had metadir enabled despite the intended configuration. That
in turn revealed that _scratch_mkfs was failing because -d rtinherit was
being respecified, so it did that obnoxious thing it does and reformats
with only the caller's mkfs options.
As a result, the scratch filesystem is configured incorrectly -- metadir
is enabled when we don't want it to be, so we pick the wrong output file
and fail.
Instead of passing -drtinherit and potentially conflicting with the test
configuration options, let's use _xfs_force_bdev to set rtinherit
programmatically.
Cc: <Hans.Holmberg@wdc.com>
Cc: <fstests@vger.kernel.org> # v2025.06.22
Fixes: e225772353e212 ("xfs: add mount test for read only rt devices")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
tests/xfs/837 | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/xfs/837 b/tests/xfs/837
index 2fe195a009f10f..33ec37ae3dbde3 100755
--- a/tests/xfs/837
+++ b/tests/xfs/837
@@ -35,7 +35,11 @@ fi
_register_cleanup "_cleanup_setrw"
-_scratch_mkfs "-d rtinherit" > /dev/null 2>&1
+_scratch_mkfs > /dev/null 2>&1
+
+_scratch_mount
+_xfs_force_bdev realtime $SCRATCH_MNT
+_scratch_unmount
# Select appropriate output file
features=""
next reply other threads:[~2026-08-26 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:30 Darrick J. Wong [this message]
2026-08-27 16:39 ` [PATCH] xfs/837: set rtinherit on the root directory programmatically Zorro Lang
2026-08-27 17:03 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826183001.GV839663@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=Hans.Holmberg@wdc.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox