Re: [PATCH 2/7] xfs: port healthmon event list to list_head

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 31, 2026 at 08:58:41AM +0200, Christoph Hellwig wrote:
> On Thu, Aug 27, 2026 at 07:47:59AM -0700, Darrick J. Wong wrote:
> > On Thu, Aug 27, 2026 at 03:03:46PM +0530, Anuj Gupta wrote:
> > > > -	if (xfs_healthmon_merge_events(hm->last_event, &lost_event)) {
> > > > -		trace_xfs_healthmon_merge(hm, hm->last_event);
> > > > +	if (xfs_healthmon_merge_events(hm, &lost_event)) {
> > > > +		trace_xfs_healthmon_merge(hm, &lost_event);
> > > 
> > > This traces the lost_event now, but the merge updates existing tail
> > > event. Is the change in behaviour intentional?
> > > 
> > > >  	/* Try to merge with the newest event */
> > > > -	if (xfs_healthmon_merge_events(hm->last_event, template)) {
> > > > -		trace_xfs_healthmon_merge(hm, hm->last_event);
> > > > +	if (xfs_healthmon_merge_events(hm, template)) {
> > > > +		trace_xfs_healthmon_merge(hm, template);
> > > 
> > > Same: the merge updates the existing tail event, but this traces the
> > > incoming template/event. Before this patch, surviving post-merge tail
> > > was traced.
> > 
> > Oops, that should become list_last_entry() for both.
> 
> Maybe move the trace inside the helper to make it more
> clear?

Will do.

--D