Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/8] xfs: move healthmon event merge tracepoint
Date: Wed, 2 Sep 2026 09:15:17 +0200	[thread overview]
Message-ID: <20260902071517.GA25977@lst.de> (raw)
In-Reply-To: <178832750309.3507776.2729420337141667342.stgit@frogsfrogsfrogs>

On Tue, Sep 01, 2026 at 10:46:56PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Move the tracepoint into the predicate function so that the list
> conversion in the next patch is easier.

I would have called the label "out_merge" or even just "merge" instead of 
"out_true", but the changes otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>


  reply	other threads:[~2026-09-02  7:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  5:41 [PATCHSET v3 4/5] xfs: LLM-inspired bug fixes, part 8 Darrick J. Wong
2026-09-02  5:46 ` [PATCH 1/8] xfs: always set xfs_healthmon::first_event when inserting at front of list Darrick J. Wong
2026-09-03  3:02   ` Anuj Gupta
2026-09-02  5:46 ` [PATCH 2/8] xfs: move healthmon event merge tracepoint Darrick J. Wong
2026-09-02  7:15   ` Christoph Hellwig [this message]
2026-09-02 15:28     ` Darrick J. Wong
2026-09-02  5:47 ` [PATCH 3/8] xfs: port healthmon event list to list_head Darrick J. Wong
2026-09-02  7:16   ` Christoph Hellwig
2026-09-02  5:47 ` [PATCH 4/8] xfs: merge healthmon insert/push helpers Darrick J. Wong
2026-09-02  5:47 ` [PATCH 5/8] xfs: check healthmon outbuffer space correctly Darrick J. Wong
2026-09-02  5:47 ` [PATCH 6/8] xfs: bump lost_prev_errors if we lose even the healthmon lost event Darrick J. Wong
2026-09-02  5:48 ` [PATCH 7/8] xfs: report nonexistent parents as a filesystem corruption Darrick J. Wong
2026-09-02  5:48 ` [PATCH 8/8] xfs: destroy seen inode bitmap when we fail to add a dirpath Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902071517.GA25977@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox