From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, hch@lst.de, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] xfs: signal inode btree xref error if get_rec returns an error
Date: Wed, 2 Sep 2026 09:21:25 +0200 [thread overview]
Message-ID: <20260902072125.GA26173@lst.de> (raw)
In-Reply-To: <178832750731.3508131.3210719479030610829.stgit@frogsfrogsfrogs>
On Tue, Sep 01, 2026 at 10:48:45PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM points out that xchk_finobt_xref_inobt and xchk_inobt_xref_finobt
> both ignore errors being returned from the xfs_btree_get_rec function
> and proceed with a (possibly stale) "true" value for has_record. If the
> *simple* btree record checks fail during cross-referencing, we can
> immediately conclude that there's a cross-referncing error in the other
> btree. On those grounds, we can bubble up the returned error instead of
> wasting time cross-referencing with garbage.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-02 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 5:41 [PATCHSET 5/5] xfs: LLM-inspired bug fixes, part 9 Darrick J. Wong
2026-09-02 5:48 ` [PATCH 1/5] xfs: signal inode btree xref error if get_rec returns an error Darrick J. Wong
2026-09-02 7:21 ` Christoph Hellwig [this message]
2026-09-02 5:49 ` [PATCH 2/5] xfs: truncate quota file correctly when repairing quota file Darrick J. Wong
2026-09-02 7:22 ` Christoph Hellwig
2026-09-02 5:49 ` [PATCH 3/5] xfs: compute dquot checksum after resetting dd_lsn in repair Darrick J. Wong
2026-09-02 7:23 ` Christoph Hellwig
2026-09-02 15:37 ` Darrick J. Wong
2026-09-03 5:35 ` Christoph Hellwig
2026-09-03 5:43 ` Darrick J. Wong
2026-09-03 5:49 ` [PATCH v1.1 " Darrick J. Wong
2026-09-02 5:49 ` [PATCH 4/5] xfs: fix backwards skipping logic in xrep_quota_block Darrick J. Wong
2026-09-02 7:24 ` Christoph Hellwig
2026-09-02 5:49 ` [PATCH 5/5] xfs: fix backwards mergeability logic in refcount scrubber Darrick J. Wong
2026-09-02 7:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902072125.GA26173@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox