From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zorro Lang <zlang@kernel.org>, fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] xfs: basic functional testing of media verification command
Date: Wed, 2 Sep 2026 09:29:33 +0200 [thread overview]
Message-ID: <20260902072933.GA26979@lst.de> (raw)
In-Reply-To: <20260826183105.GX839663@frogsfrogsfrogs>
> diff --git a/common/xfs b/common/xfs
> index 81add2086866c8..8dec3475579e40 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -1786,6 +1786,9 @@ _xfs_filter_mkfs()
> }
> if (/^\s+=\s+rgcount=(\d+)\s+rgsize=(\d+) extents/) {
> print STDERR "rgcount=$1\nrgextents=$2\n";
> + }
> + if (/^\s+=\s+zoned=(\d+)\s+start=(\d+) reserved=(\d+)/) {
> + print STDERR "zoned=$1\nrtstart=$2\nrtreserved=$3\n";
> }'
How is this related? Maybe split it out into a well-doumented patch?
Also does the ' after the } break the usage?
> +
> +# Make the data and rt volumes small enough that this won't take forever
> +# on large slow devices.
> +_scratch_mkfs_sized $((600 * 1024 * 1024)) | _filter_mkfs 2>$tmp.mkfs >> $seqres.full
Split the overly long line?
Otherwise this looks good to me.
next prev parent reply other threads:[~2026-09-02 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:31 [PATCH] xfs: basic functional testing of media verification command Darrick J. Wong
2026-09-02 7:29 ` Christoph Hellwig [this message]
2026-09-02 15:20 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902072933.GA26979@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox