From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, cem@kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs: fix rtrefcount btree block counting in scrub
Date: Thu, 3 Sep 2026 08:10:07 +0200 [thread overview]
Message-ID: <20260903061007.GD17233@lst.de> (raw)
In-Reply-To: <178840969914.484660.12780329653421744867.stgit@frogsfrogsfrogs>
On Wed, Sep 02, 2026 at 10:51:52PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM started on a long tangent about how xchk_refcount_xref_rmap
> shouldn't nope out if sc->sa.rmap_cur isn't set, because nothing ever
> sets that field. It's right about the condition, but misses the bigger
> problem,
I see a pattern there :)
> which is that to count the rtrefcount btree blocks, we have to
> walk all rmap records in each AG in the data section. That was papered
> over by the incorrect !sc->sa.rmap_cur test.
>
> In other words, we need a perag iteration loop here. Restructure the
> code to do that, and now it'll all work properly. Fix the confusing
> function name prefix.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-03 6:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 5:51 [PATCHSET] xfs: LLM-inspired bug fixes, part 10 Darrick J. Wong
2026-09-03 5:51 ` [PATCH 1/6] xfs: cross-reference the rtgroup superblock extent, not block Darrick J. Wong
2026-09-03 6:04 ` Christoph Hellwig
2026-09-03 5:51 ` [PATCH 2/6] xfs: use the rtgroup extent count to find rtrefcount gaps Darrick J. Wong
2026-09-03 6:07 ` Christoph Hellwig
2026-09-03 5:51 ` [PATCH 3/6] xfs: strengthen the "is cow staging" helpers in scrub Darrick J. Wong
2026-09-03 6:08 ` Christoph Hellwig
2026-09-03 5:51 ` [PATCH 4/6] xfs: fix rtrefcount btree block counting " Darrick J. Wong
2026-09-03 6:10 ` Christoph Hellwig [this message]
2026-09-03 5:52 ` [PATCH 5/6] xfs: make the rtsummary repair fix the file size too Darrick J. Wong
2026-09-03 6:11 ` Christoph Hellwig
2026-09-03 5:52 ` [PATCH 6/6] xfs: count escaped corruption errors in scrub stats Darrick J. Wong
2026-09-03 6:11 ` Christoph Hellwig
2026-09-07 6:29 ` [PATCHSET] xfs: LLM-inspired bug fixes, part 10 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903061007.GD17233@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox