From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94350473C84 for ; Fri, 4 Sep 2026 11:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788521565; cv=none; b=VxUyFjo+z+TgOllvk4TLQ/p4utmetk5HEfZu1pkCLtC+MFLuj/xiwtXL4hNUspcz/rLmUChI5exUojHgn8jCINZQtXCvxexJzA9iuf3ayTJcX0XVf9wLc4tM67tsQA09uiQIokaptzZp2OjqLHNZsZzy/fKlWf3pphfBZCZHmLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788521565; c=relaxed/simple; bh=QoGiWO2hT2IAKBwADdlO8qkY3cGvpKCHC/+1f4SNetg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WFmKKPywbmIhHr0wvBr90YL+4hSZg6XeHeKlJul4qFfRWdzXfgMarKUxyEbgJeoaXJhUZtJBSySjaOtbfzutF7vW/FpmGbUS2bi4AatGzGd3eTNlS6WFozQ9nMP0dXd62kgs1pO/TO4bZ7W0x76a0VQhMe4UHqPPeKzWBUtba+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f72KTzmc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f72KTzmc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CBDF1F00A3E for ; Fri, 4 Sep 2026 11:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788521563; bh=Wc8khL6680j1gTfBE0qdWmH0TLGl/UPNn0RsWcRSVoU=; h=From:To:Subject:Date:In-Reply-To:References; b=f72KTzmc9G51sFLF9sdfGc3V7DTgee/HcwMTak1AaWeiThVZRSeu1zaw3x6K51G/6 I63DEbCOxKhiFdGVxvL0xci9efaglJkO9KDtCgoFoP+IzYC+LUpR6hyVB9hYzH8yLo WTmavZo5LqEY6V4TaDv5eZ2gyJwAWK6OcIMFRESw5DzTsmtiRlLw7Fr8S6x3OJ4Be+ +eJJTvHNj15HutuXXnp+n0fQtMkLDaEHWnOKEYvR4vOMQM60HI/eS8OjlLGraixMBv Ywjp+9t0yDXEVS1OzWn4FdAb6MMTMdeGvPSPMkp7LRRPncrdzX3NP+qipB79Gt0srJ wIjytcL/b5K5w== From: cem@kernel.org To: linux-xfs@vger.kernel.org Subject: [RFC PATCH 1/3] xfs: add xfs_error_report the ability to display an error code Date: Fri, 4 Sep 2026 13:32:21 +0200 Message-ID: <20260904113231.1408890-2-cem@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904113231.1408890-1-cem@kernel.org> References: <20260904113231.1408890-1-cem@kernel.org> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Carlos Maiolino Users could opt to request an error code to be printed Signed-off-by: Carlos Maiolino Signed-off-by: Carlos Maiolino --- fs/xfs/xfs_error.c | 7 ++++++- fs/xfs/xfs_error.h | 10 +++++----- fs/xfs/xfs_exchmaps_item.c | 6 +++--- fs/xfs/xfs_inode_item.c | 2 +- fs/xfs/xfs_log_recover.c | 2 +- 5 files changed, 16 insertions(+), 11 deletions(-) diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c index dbd87e137694..1c882b910ffd 100644 --- a/fs/xfs/xfs_error.c +++ b/fs/xfs/xfs_error.c @@ -377,6 +377,7 @@ void xfs_error_report( const char *tag, int level, + int error, struct xfs_mount *mp, const char *filename, int linenum, @@ -387,6 +388,10 @@ xfs_error_report( "Internal error %s at line %d of file %s. Caller %pS", tag, linenum, filename, failaddr); + if (error) + xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT, + "Error Code: %d", error); + xfs_stack_trace(); } } @@ -404,7 +409,7 @@ xfs_corruption_error( { if (buf && level <= xfs_error_level) xfs_hex_dump(buf, bufsize); - xfs_error_report(tag, level, mp, filename, linenum, failaddr); + xfs_error_report(tag, level, 0, mp, filename, linenum, failaddr); xfs_alert(mp, "Corruption detected. Unmount and run xfs_repair"); } diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h index 0b9c5ba8a598..1a1aa60e92f2 100644 --- a/fs/xfs/xfs_error.h +++ b/fs/xfs/xfs_error.h @@ -8,9 +8,9 @@ struct xfs_mount; -extern void xfs_error_report(const char *tag, int level, struct xfs_mount *mp, - const char *filename, int linenum, - xfs_failaddr_t failaddr); +extern void xfs_error_report(const char *tag, int level, int error, + struct xfs_mount *mp, const char *filename, + int linenum, xfs_failaddr_t failaddr); extern void xfs_corruption_error(const char *tag, int level, struct xfs_mount *mp, const void *buf, size_t bufsize, const char *filename, int linenum, @@ -25,8 +25,8 @@ extern void xfs_inode_verifier_error(struct xfs_inode *ip, int error, const char *name, const void *buf, size_t bufsz, xfs_failaddr_t failaddr); -#define XFS_ERROR_REPORT(e, lvl, mp) \ - xfs_error_report(e, lvl, mp, __FILE__, __LINE__, __return_address) +#define XFS_ERROR_REPORT(e, lvl, error, mp) \ + xfs_error_report(e, lvl, error, mp, __FILE__, __LINE__, __return_address) #define XFS_CORRUPTION_ERROR(e, lvl, mp, buf, bufsize) \ xfs_corruption_error(e, lvl, mp, buf, bufsize, \ __FILE__, __LINE__, __return_address) diff --git a/fs/xfs/xfs_exchmaps_item.c b/fs/xfs/xfs_exchmaps_item.c index 264a121c5e16..b94c5e5e6549 100644 --- a/fs/xfs/xfs_exchmaps_item.c +++ b/fs/xfs/xfs_exchmaps_item.c @@ -559,13 +559,13 @@ xlog_recover_xmi_commit_pass2( len = sizeof(struct xfs_xmi_log_format); if (item->ri_buf[0].i_len != len) { - XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, log->l_mp); + XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, log->l_mp); return -EFSCORRUPTED; } xmi_formatp = item->ri_buf[0].i_addr; if (xmi_formatp->__pad != 0) { - XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, log->l_mp); + XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, log->l_mp); return -EFSCORRUPTED; } @@ -600,7 +600,7 @@ xlog_recover_xmd_commit_pass2( xmd_formatp = item->ri_buf[0].i_addr; if (item->ri_buf[0].i_len != sizeof(struct xfs_xmd_log_format)) { - XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, log->l_mp); + XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, log->l_mp); return -EFSCORRUPTED; } diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c index c6cb0b6b9e46..862b7d7d3ce4 100644 --- a/fs/xfs/xfs_inode_item.c +++ b/fs/xfs/xfs_inode_item.c @@ -1185,7 +1185,7 @@ xfs_inode_item_format_convert( struct xfs_inode_log_format_32 *in_f32 = buf->i_addr; if (buf->i_len != sizeof(*in_f32)) { - XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, NULL); + XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, NULL); return -EFSCORRUPTED; } diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index 2f76531842f8..083e4bf61e2b 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -2932,7 +2932,7 @@ xlog_recover_process( * fatal log corruption failure. */ if (xfs_has_crc(log->l_mp)) { - XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, log->l_mp); + XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, log->l_mp); return -EFSCORRUPTED; } } -- 2.55.0