Linux XFS filesystem development
 help / color / mirror / Atom feed
From: cem@kernel.org
To: cem@kernel.org
Cc: hch@lst.de, djwong@kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 0/3] Enable xfs error reporting to print out error codes
Date: Tue,  8 Sep 2026 16:54:13 +0200	[thread overview]
Message-ID: <20260908145422.232985-1-cem@kernel.org> (raw)

From: Carlos Maiolino <cem@kernel.org>

Hello.

This is the first 'formal' version of this series after a round of
RFC...

The goal remains the same, enabling us to easily find what error
caused a transaction to be cancelled. But the infra-structure is usable
for remaining error cases.

The main updates regarding the RFC version is xfs_error_report now
uses errname() to print out the error.

Also gets rid of the unneeded extern modifier from it.

Instead of a variadic function uses a couple different macros to select
between with/without error. I named it xfs_trans_cancel_error() because
it sounded clear to me than the _with() suffix. I'd not join an argument
to defent one or another though if you guys are unhappy with _error,
I'll change back to _with().

Last patch is simple enough and I kept Darrick's review on it as there
is not much change in there other than setting up the right macro.

Cheers.

Carlos Maiolino (3):
  xfs: add xfs_error_report the ability to display an error code
  xfs: enable xfs_trans_cancel() to report and error code
  xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel

 fs/xfs/xfs_error.c         | 13 ++++++++++---
 fs/xfs/xfs_error.h         | 10 +++++-----
 fs/xfs/xfs_exchmaps_item.c |  9 ++++++---
 fs/xfs/xfs_inode_item.c    |  3 ++-
 fs/xfs/xfs_iomap.c         |  2 +-
 fs/xfs/xfs_log_recover.c   |  3 ++-
 fs/xfs/xfs_trans.c         |  8 +++++---
 fs/xfs/xfs_trans.h         |  6 +++++-
 8 files changed, 36 insertions(+), 18 deletions(-)

-- 
2.55.0


             reply	other threads:[~2026-09-08 14:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 14:54 cem [this message]
2026-09-08 14:54 ` [PATCH 1/3] xfs: add xfs_error_report the ability to display an error code cem
2026-09-08 15:16   ` Darrick J. Wong
2026-09-10  9:24     ` Carlos Maiolino
2026-09-08 16:53   ` Eric Sandeen
2026-09-08 17:02     ` Darrick J. Wong
2026-09-08 20:40       ` Eric Sandeen
2026-09-10  9:33         ` Carlos Maiolino
2026-09-08 14:54 ` [PATCH 2/3] xfs: enable xfs_trans_cancel() to report and " cem
2026-09-08 15:27   ` Darrick J. Wong
2026-09-10  9:17     ` Carlos Maiolino
2026-09-08 14:54 ` [PATCH 3/3] xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel cem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908145422.232985-1-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox