From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8F3443C12 for ; Fri, 11 Sep 2026 10:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122373; cv=none; b=aZEGekEMQXhvyV/bph5f7omthY08ueRZTvlYfLieLBTQTWWzDfbaAtYOkp3GE7Mwim/1YRiG/qnGLQI1dAQZm1jLEAACInghjI1zVpE2gZSWdHiXajgiNLvZV445hw/jux93SdhGjnpB/TTxUqybUc+8Sy09Fnbh+RHliUBxvmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122373; c=relaxed/simple; bh=eqVZgeBn3pFGkDvZueVueXd23kt1HUk/Ka9kdogQI7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n+a9Rp18XszTCbqi4SsOWBfPgB6GLmCDP+eoYGWZhj92vdWvgOLrXXsf+eQsdOG7Cpm5nK8IUf4xtUWsp8qmjOtRtVOf9XGRKrlXJsJ/CS42g4aPMJ6D+0zaRirrSvA1V/itxNpBVNF1tf+bCObXwlNV/akbALYpO88BCmjolsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aCAzeJty; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aCAzeJty" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2d9520b9155so7684625ad.3 for ; Fri, 11 Sep 2026 03:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789122370; x=1789727170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yz8Wf/76e1pwHAM3SmDXbmtzcXfyZlPBJr/oXRWCwns=; b=aCAzeJtyyg8KnJWpOVWtsobv94cf9zhcRY0fZGNfkg6vh7xDkj0ewh6bH38ReXLM2D 5nQ0a90TJ87P4HwrImPZyaAd+ORZfO85WeohyYFS4YFfuy3OYez67r5kXrXcURdcprZZ NvTq/xY2uhtdfKu60r/gFBk2y1Y1plfqRSle6I3u43LHeDRhBPM+A4ilOuki97iUxN96 G7C4NV7HItwMjlwPQYl0RSrOExPJK4y4jN6r25HAYimnoeGukseU7OuejkUiVra6gAEw RfTvdE0MfGcdGaNyHy2G68RfiCpPG0Chys/5/S8qUpFywcQNP4fgSXRCnas2Z1lMSL8K pIBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122370; x=1789727170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yz8Wf/76e1pwHAM3SmDXbmtzcXfyZlPBJr/oXRWCwns=; b=j+ZDJE5t1U+TmlHtlzeujxD7LZ7GLGEEgupNaveU6zUskrespXnMHE40K0stlYrVIi oFcLYoBAfPeaVoZwaVo3fvzARNUMhuFkdVqVsSF9ewmLeQCgJpJM/imyd0lSngKDTDUn Du3y9fPYak39YksXOQTXtBbOl3y6xwssyo4lKtAxvyNLx7i6WmMPUBQrv0U4DxUsF5Sz SFx9WaZjlrtt/oIR63svnD0MvfGa3V2egHnmCaLCpXMg6Ktuz2EgG4T73hWn512MKsdp pDuX5N02jUQRsawt6k4MYc/YN+eZiUsbcPEebcO9qkNzbRQ+GcPVuZWLPCm/yDU9aYpX wYUQ== X-Forwarded-Encrypted: i=1; AKwUvBxRlJk1o26IhDMhiWd4M0PQ20VBsmdKP8C40RG4do7a2A4Oy7yV2hEqVPFwiP6M9QiwaUCkZRmDZV4=@vger.kernel.org X-Gm-Message-State: AFuF++n1so54knHjQ0KVLGb1lEem1bduHf1+VJJxKmiDMqWjbImHyxob ECoCWGBmD9gsWNUfeFv7DGxefeifsTLN20fVG95+HnWHRBoB9qsLltUi X-Gm-Gg: AYBFou1GSNEalUUJmx/Da8nOkNNtnLEj3XTnNw+sigTXsq4dhNqgIKklQWDNbuY/m+1 NcdlDrO4CRE/Kd08C34PY8W3Gw7sPavuu7rYTEURjvVJfq6YWSBQPF0BjIEHN7jqYvg+RmL1a61 uJ6qLWZhicvCvQxw+asjxFf+NAfZk8B05v1H4mv8vsIOm2R9eIe5Ty2HJORWmiv1ZesPs9hmYaA oIPltOLESV7khLP5kjWAO6acTRvgTWzQQQBQYayijISQzME39YSKmeeCUTzIAYDPE50BTVo4F+O BM2V88q+ksu06B+Nu3kYLhlgeyoaLWeO/cpfrEo7pxN2EsQRWguJS9GSKSYvEgd+ZnDyknM8R0V CE6bW9lyWoD/wUKd8AUX3X8kOXuMOAKxMLTBymoo45TYn/dj9cWELIup3akeezBVTc6QiY+lkNM WQXvR8AklMP4U4ZIJeDcP4mwKUxsBSO3AJfuEe/ihTvKkgkorOqCYbC3Sy9zSVu7zlddPYeYiWc DB4 X-Received: by 2002:a17:902:ce0f:b0:2dd:8b2:6e64 with SMTP id d9443c01a7336-2dd2a336804mr84860135ad.12.1789122369587; Fri, 11 Sep 2026 03:26:09 -0700 (PDT) Received: from Default ([2409:40f4:1034:ff33:e7d7:d190:816c:e597]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4ed295esm6220095eec.15.2026.09.11.03.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:26:08 -0700 (PDT) From: Jeffin Philip To: cem@kernel.org Cc: dgc@kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeffin Philip Subject: [RFC PATCH 2/2] xfs: change xfs_trans_ail_delete return type to bool Date: Fri, 11 Sep 2026 15:55:02 +0530 Message-ID: <20260911102502.163566-3-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260911102502.163566-1-jeffinphilip14@gmail.com> References: <20260911102502.163566-1-jeffinphilip14@gmail.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change xfs_trans_ail_delete's return type from void to bool which returns true if the item was removed from AIL and false in case of shutdown(item not in AIL). Reflect the change in header file too. Signed-off-by: Jeffin Philip --- fs/xfs/xfs_trans_ail.c | 5 +++-- fs/xfs/xfs_trans_priv.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c index 99a9bf3762b7..b17b677586a0 100644 --- a/fs/xfs/xfs_trans_ail.c +++ b/fs/xfs/xfs_trans_ail.c @@ -913,7 +913,7 @@ xfs_ail_delete_one( return 0; } -void +bool xfs_trans_ail_delete( struct xfs_log_item *lip, int shutdown_type) @@ -931,12 +931,13 @@ xfs_trans_ail_delete( __func__); xlog_force_shutdown(log, shutdown_type); } - return; + return false; } clear_bit(XFS_LI_FAILED, &lip->li_flags); tail_lsn = xfs_ail_delete_one(ailp, lip); xfs_ail_update_finish(ailp, tail_lsn); /* drops the AIL lock */ + return true; } int diff --git a/fs/xfs/xfs_trans_priv.h b/fs/xfs/xfs_trans_priv.h index f945f0450b16..b00c803941c7 100644 --- a/fs/xfs/xfs_trans_priv.h +++ b/fs/xfs/xfs_trans_priv.h @@ -100,7 +100,7 @@ void xfs_trans_ail_insert(struct xfs_ail *ailp, struct xfs_log_item *lip, xfs_lsn_t xfs_ail_delete_one(struct xfs_ail *ailp, struct xfs_log_item *lip); void xfs_ail_update_finish(struct xfs_ail *ailp, xfs_lsn_t old_lsn) __releases(ailp->ail_lock); -void xfs_trans_ail_delete(struct xfs_log_item *lip, int shutdown_type); +bool xfs_trans_ail_delete(struct xfs_log_item *lip, int shutdown_type); static inline void xfs_ail_push(struct xfs_ail *ailp) { -- 2.55.0