From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrey Albershteyn <aalbersh@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] libxfs: don't set mp->m_rtdev_targp when no RT devices is provided
Date: Fri, 11 Sep 2026 17:11:20 +0200 [thread overview]
Message-ID: <20260911151120.GA26893@lst.de> (raw)
In-Reply-To: <20260911145726.GE6265@frogsfrogsfrogs>
On Fri, Sep 11, 2026 at 07:57:26AM -0700, Darrick J. Wong wrote:
> > - if (!xi->rt.dev || xi->rt.dev == xi->data.dev)
> > + if (xi->rt.dev == xi->data.dev)
> > mp->m_rtdev_targp = mp->m_ddev_targp;
> > else
> > mp->m_rtdev_targp = libxfs_buftarg_alloc(mp, xi, &xi->rt,
>
> Does this mean that m_rtdev_targp is never NULL, even when we don't
> specify or have a rt device attached?
I think that is the case right now.
> I would have expected this to be:
>
> if (!xi->rt.dev)
> mp->m_rtdev_targp = NULL;
> else if (xi->rt.dev == xi->data.dev)
> mp->m_rtdev_targp = mp->m_ddev_targp;
> else
> mp->m_rtdev_targp = libxfs_buftarg_alloc(...);
And that is what we get with this patch. The zeroing is done by
zeroing the entire mount structure in the callers of libxfs_mount
(don't ask me why..).
next prev parent reply other threads:[~2026-09-11 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 14:45 fix missing RT detection in libxfs Christoph Hellwig
2026-09-11 14:45 ` [PATCH 1/3] libxfs: don't set mp->m_rtdev_targp when no RT devices is provided Christoph Hellwig
2026-09-11 14:57 ` Darrick J. Wong
2026-09-11 15:11 ` Christoph Hellwig [this message]
2026-09-11 15:30 ` Darrick J. Wong
2026-09-11 15:38 ` Christoph Hellwig
2026-09-11 14:45 ` [PATCH 2/3] libxfs: better describe why m_ddev_targp can be set in libxfs_buftarg_init Christoph Hellwig
2026-09-11 14:53 ` Darrick J. Wong
2026-09-11 14:45 ` [PATCH 3/3] libxfs: remove buftarg member aliases Christoph Hellwig
2026-09-11 14:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911151120.GA26893@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox