Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: Eric Sandeen <sandeen@redhat.com>
Subject: [PATCH 02/14] xfs: remove unused rsvd argument from xfs_bmap_add_attrfork()
Date: Mon, 14 Sep 2026 15:46:07 -0500	[thread overview]
Message-ID: <20260914205221.1516254-3-sandeen@redhat.com> (raw)
In-Reply-To: <20260914205221.1516254-1-sandeen@redhat.com>

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
 fs/xfs/libxfs/xfs_attr.c    | 2 +-
 fs/xfs/libxfs/xfs_bmap.c    | 3 +--
 fs/xfs/libxfs/xfs_bmap.h    | 2 +-
 fs/xfs/scrub/inode_repair.c | 2 +-
 fs/xfs/scrub/orphanage.c    | 2 +-
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index 8fb3adc3dd2d..c4bb59633ce8 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -1013,7 +1013,7 @@ xfs_attr_add_fork(
 	if (xfs_inode_has_attr_fork(ip))
 		goto trans_cancel;
 
-	error = xfs_bmap_add_attrfork(tp, ip, size, rsvd);
+	error = xfs_bmap_add_attrfork(tp, ip, size);
 	if (error)
 		goto trans_cancel;
 
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index d64defeda645..ca147dfaed05 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -1026,8 +1026,7 @@ int						/* error code */
 xfs_bmap_add_attrfork(
 	struct xfs_trans	*tp,
 	struct xfs_inode	*ip,		/* incore inode pointer */
-	int			size,		/* space new attribute needs */
-	int			rsvd)		/* xact may use reserved blks */
+	int			size)		/* space new attribute needs */
 {
 	struct xfs_mount	*mp = tp->t_mountp;
 	int			logflags;	/* logging flags */
diff --git a/fs/xfs/libxfs/xfs_bmap.h b/fs/xfs/libxfs/xfs_bmap.h
index d5f2729305fa..60f6df4ce057 100644
--- a/fs/xfs/libxfs/xfs_bmap.h
+++ b/fs/xfs/libxfs/xfs_bmap.h
@@ -181,7 +181,7 @@ void	xfs_trim_extent(struct xfs_bmbt_irec *irec, xfs_fileoff_t bno,
 		xfs_filblks_t len);
 unsigned int xfs_bmap_compute_attr_offset(struct xfs_mount *mp);
 int	xfs_bmap_add_attrfork(struct xfs_trans *tp, struct xfs_inode *ip,
-		int size, int rsvd);
+		int size);
 void	xfs_bmap_local_to_extents_empty(struct xfs_trans *tp,
 		struct xfs_inode *ip, int whichfork);
 int xfs_bmap_local_to_extents(struct xfs_trans *tp, struct xfs_inode *ip,
diff --git a/fs/xfs/scrub/inode_repair.c b/fs/xfs/scrub/inode_repair.c
index 8bc508336aa5..42e0d7a6c7fd 100644
--- a/fs/xfs/scrub/inode_repair.c
+++ b/fs/xfs/scrub/inode_repair.c
@@ -1949,7 +1949,7 @@ xrep_inode_pptr(
 		return 0;
 
 	return xfs_bmap_add_attrfork(sc->tp, ip,
-			sizeof(struct xfs_attr_sf_hdr), true);
+			sizeof(struct xfs_attr_sf_hdr));
 }
 
 /* Fix COW extent size hint problems. */
diff --git a/fs/xfs/scrub/orphanage.c b/fs/xfs/scrub/orphanage.c
index 3aca66869b80..8c9f323201b4 100644
--- a/fs/xfs/scrub/orphanage.c
+++ b/fs/xfs/scrub/orphanage.c
@@ -546,7 +546,7 @@ xrep_adoption_move(
 	if (!xfs_inode_has_attr_fork(sc->ip) && xfs_has_parent(sc->mp)) {
 		int sf_size = xrep_adoption_attr_sizeof(adopt);
 
-		error = xfs_bmap_add_attrfork(sc->tp, sc->ip, sf_size, true);
+		error = xfs_bmap_add_attrfork(sc->tp, sc->ip, sf_size);
 		if (error)
 			return error;
 	}
-- 
2.55.0


  parent reply	other threads:[~2026-09-14 20:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 20:46 [PATCH 0/14] xfs: remove unused arguments from many functions Eric Sandeen
2026-09-14 20:46 ` [PATCH 01/14] xfs: remove unused args argument from xfs_attr_node_lookup() Eric Sandeen
2026-09-14 20:46 ` Eric Sandeen [this message]
2026-09-14 20:46 ` [PATCH 03/14] xfs: remove unused mp and ops arguments from xfbtree_rec_bytes() Eric Sandeen
2026-09-14 20:46 ` [PATCH 04/14] xfs: remove unused mp argument from xfs_exchmaps_check_forks() Eric Sandeen
2026-09-14 20:46 ` [PATCH 05/14] xfs: remove unused mp argument from xfs_inobt_rec_check_count() Eric Sandeen
2026-09-14 20:46 ` [PATCH 06/14] xfs: remove unused mp argument from xfs_parent_finish() Eric Sandeen
2026-09-14 20:46 ` [PATCH 07/14] xfs: remove unused tp argument from xfs_rmap_update_hook() Eric Sandeen
2026-09-14 20:46 ` [PATCH 08/14] xfs: remove unused mp argument from xfs_rtrefcount_broot_space_calc() Eric Sandeen
2026-09-14 20:46 ` [PATCH 09/14] xfs: remove unused mp argument from xfs_rtrefcount_broot_space() Eric Sandeen
2026-09-14 20:46 ` [PATCH 10/14] xfs: remove unused mp argument from xfs_rtrmap_broot_space_calc() Eric Sandeen
2026-09-14 20:46 ` [PATCH 11/14] xfs: remove unused mp argument from xfs_calc_default_atomic_ioend_reservation() Eric Sandeen
2026-09-14 20:46 ` [PATCH 12/14] xfs: remove unused mp argument from xfs_verify_dablk() Eric Sandeen
2026-09-14 20:46 ` [PATCH 13/14] xfs: remove unused mp argument from xfs_verify_fileoff() Eric Sandeen
2026-09-14 20:46 ` [PATCH 14/14] xfs: remove unused mp argument from xfs_verify_fileext() Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914205221.1516254-3-sandeen@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox