Re: [PATCH V2 0/14] xfs: remove unused arguments from many functions

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Sep 14, 2026 at 05:28:46PM -0500, Eric Sandeen wrote:
> V2: Sorry, that was stale already. This is against for-next in
>     https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git :(
> 
> Seems it's cleanup season lately on the list, so figured I'd play
> too.
> 
> This removes unused arguments (mostly mp) from a bunch of functions.
> 
> I did a quick check of the xfsprogs port, and it should be fine.
> (Left out xfs_rmapbt_maxrecs changes for that reason; all the
> .maxrecs functions in xfs_db need to match.)
> 
> Assisted-by: gcc version 15.3.1 20260722 (Red Hat 15.3.1-1) (GCC)

Giant Cognitive Computer?  Never heard of this model, is it any good?

> Total diffstat:

The whole series looks fine to me, assuming that the build robots don't
cough up errors & fstests doesn't explode.  For the series,

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> $ git diff 654ae5d73c05.. | diffstat
>  libxfs/xfs_attr.c             |   14 ++++++--------
>  libxfs/xfs_bmap.c             |    5 ++---
>  libxfs/xfs_bmap.h             |    2 +-
>  libxfs/xfs_btree_mem.c        |    6 ++----
>  libxfs/xfs_exchmaps.c         |    1 -
>  libxfs/xfs_exchmaps.h         |    3 +--
>  libxfs/xfs_ialloc.c           |    2 +-
>  libxfs/xfs_ialloc_btree.c     |    1 -
>  libxfs/xfs_ialloc_btree.h     |    5 ++---
>  libxfs/xfs_metadir.c          |    2 +-
>  libxfs/xfs_parent.h           |    1 -
>  libxfs/xfs_rmap.c             |   13 ++++++-------
>  libxfs/xfs_rtrefcount_btree.c |    8 ++++----
>  libxfs/xfs_rtrefcount_btree.h |    5 ++---
>  libxfs/xfs_rtrmap_btree.c     |    6 +++---
>  libxfs/xfs_rtrmap_btree.h     |    3 +--
>  libxfs/xfs_trans_resv.c       |    7 +++----
>  libxfs/xfs_types.c            |    7 ++-----
>  libxfs/xfs_types.h            |    7 +++----
>  scrub/bmap.c                  |    9 ++++-----
>  scrub/bmap_repair.c           |    4 ++--
>  scrub/inode_repair.c          |    6 +++---
>  scrub/orphanage.c             |    2 +-
>  scrub/quota.c                 |    2 +-
>  scrub/quota_repair.c          |    4 ++--
>  scrub/rtrefcount_repair.c     |    3 +--
>  scrub/rtrmap_repair.c         |    2 +-
>  xfs_bmap_item.c               |    2 +-
>  xfs_exchmaps_item.c           |    4 ++--
>  xfs_exchrange.c               |    2 +-
>  xfs_inode.c                   |   20 ++++++++++----------
>  xfs_rmap_item.c               |    2 +-
>  xfs_super.c                   |    2 +-
>  xfs_symlink.c                 |    4 ++--
>  34 files changed, 73 insertions(+), 93 deletions(-)
> 
> 
>