From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425AE41F35A for ; Wed, 23 Sep 2026 23:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790207838; cv=none; b=gOViS1LU5OUF4DFqCgChTASOAEFOlmCsw1NW5RIsU0NFjlyiU7SmBlGLiNcrA7E7Ucq53ntClUV834YWY4oIehp25Jp1RmEomNaaQug5wUEWvxasX1kupAthMyiiv0gkLwfBH/y2B8dPlGVidaaRNb5p9m82lb0paHArRwW/TM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790207838; c=relaxed/simple; bh=YMDQDXgHvisSOsY3WQrY2kVt6FOq3O9Ypoh2P+vxzKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oNf7iQGsDQn/A2DQLvmO6wUBwkSaHIHA1vl3wjeQdvFNmIVg1j6LBuGU3IPYgQZ9u0ks9WAS43Dg1HEF+voGVYXJIn97xC8ZrobBtKUOf6mEEoMYcMQHL2AEU2CDRCf9SXI8EjdBUhpeoFZhzb3TdR+jbJCAY+TWAFmQwtWSr4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=PDW2zhaR; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=d1hDZ1Vz; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="PDW2zhaR"; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="d1hDZ1Vz" Received: from pps.filterd (m0167069.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NNErbV047796 for ; Wed, 23 Sep 2026 19:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=cc0o mFVdeKpkhDBaIU83p8O9yx2QegCmTSxi6DGn1/0=; b=PDW2zhaRmjM/PwcRtiGz eZ2hTCCD6j86/uM17aF8r64rYhw73ssG5EIwsHgmc2WZqh3ZAj4B2gaHBBrllJym HJiQemEpkr49/l6zx1HsK5MAF1dgwxwY6F4rMZmyyCcDEzys9UoYDByrfwFCvYeF 3LadGeN0h5eMPgrSjVDkVLcyK+O/DcpcK926aaFVe57qj49wWTB0BvGPFCbyYkxS YVOnMfyPnnYzBd0zvQzoeaf1GDH4c9cfbW3la8dsc2/STmFrJHxhycAbB699Lixh NpTPNWLQfrMA9MGTls7vwldTjrB+XcGoJhv3Diorn2clMAie7GlBiMTiD7f9eKYe 5g== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4gvhrem5mp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 23 Sep 2026 19:57:09 -0400 (EDT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc7361c62b9so1047847a12.3 for ; Wed, 23 Sep 2026 16:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; s=lionmail; t=1790207829; x=1790812629; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cc0omFVdeKpkhDBaIU83p8O9yx2QegCmTSxi6DGn1/0=; b=d1hDZ1VzyJpDXi/AqWmaDPuJSIJXuFs7q0jQDQl9ae4hsl9LHnQhxLEHUL82Y3mGT+ GZ7v73bSrY5bvqaIS18A0CKA0+cT6EEsRicXaLBWL5hVQ+9UTDrt1ItQJ6Q9BhO0q9N2 tbIbrKMsptsMSSj4QXJmp3BBfG8cP6fA50knLCY3e2AES4WmVjOC/L/ifaSTxWh2tIZD 6JaY4NWvlalghQM/8KvCj4fPFVlN8s9u/B2jbWmkvjb7Sa3bd8rdxsCHc/ZQSo2aqoGn XzaNucc3jZDmW92K4XId6hRgH8nCTnSePQVKeTfsxmRdNiRBR9pm7FZAsN4Gz6ivLuEy WfMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790207829; x=1790812629; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cc0omFVdeKpkhDBaIU83p8O9yx2QegCmTSxi6DGn1/0=; b=lmdKv03dUFt086T6oJD1NIyrg3VsEf5PDtF1X5MivOasv8WMnjZ0zq8e13Ut/WikyG jM2OGOzv2SM5+QyzcoaEMBUAMyI2XpahyeERt4oPE3vXPtrTB7PWPItYvJN3JdhKExfL evn+A1O9Qstwog1lrAPqREq0WBrEvFywdiq4Yhmyt8rYCW/u0Mo1JODuJVa/2t0ih8tA ZV5j5NhyRi2d6Px0qgUSWKAfpbZJr+2asZvucYGdmWzJtumLmv3kT5zTMLX08Ogu9GHV Xe82edt0QCuiflfvR+8pnCFUbpX3BWmrv/Ex/px5sLYLb6G/8SXSrald/+Ol/i44WZsg mJyg== X-Forwarded-Encrypted: i=1; AKwUvByzI+OjexrpkVnv1+4aLGh6FFgXKCUrM2jB2Knc0vjpcQWS9MPRLcvRQ5Rwj4AdrDWWO/sJetHXoDU=@vger.kernel.org X-Gm-Message-State: AFuF++lY2dnsZsU1TBjWZZi0/ibNUPkEIy6bRlYlQ4km0z5l41D8/m1I 10sQB+DipQUYewqQDfPOkqjP+8PJ9REkhf48sP1W+ZRmfQdsRfGwmZnWIH5br4DYL6/OewWZpXU Kh3aLXUFCE0HFBawdRPMuT2TMU+DXKbfEHMSmWCBD+5VZKW34FG+dHc5i7uN4f3Fcqg== X-Gm-Gg: AYBFou1Xr/tdWf6NOkHA7n38kkTrKBMIRNinjFc1oTjRvvKQn+P4aFItpFYPbRdMj++ mUC3fOCHfbwaw6Xl8ckjSlgBkRgMkj+BGdK7kYe6IuH8+rVlH5HcIG4UtO+A/DOJYQ+yV3upemM It40aSjkRWI/OAqkpfmkEYsZ9cGJ9rAoCDbNLZZnVUoeoU7ZjbhGGUBTY09O3H7V0+mwQ5DoBIk Mq/eO8aGWOOHNWq03Qv+RauwuTCN3VhnPSUJXESYYWwTtwp+aXFabd7FDk64A3wL/zEIzywvsCx Nz1qjQE6bAxZqXBtykXiEpUvoo4B4jxchW6QntclXqAw16TDPhuCoDjK4IPjRj4bRBDzvNo78I6 sdFU+SthVbbk1O1PgmwPD+Xck4ZRkG9PtJuXa8RrOvRYa+w== X-Received: by 2002:a17:90b:4fc8:b0:39d:f4fd:8075 with SMTP id 98e67ed59e1d1-3a098ce492amr490418a91.19.1790207828817; Wed, 23 Sep 2026 16:57:08 -0700 (PDT) X-Received: by 2002:a17:90b:4fc8:b0:39d:f4fd:8075 with SMTP id 98e67ed59e1d1-3a098ce492amr490405a91.19.1790207828356; Wed, 23 Sep 2026 16:57:08 -0700 (PDT) Received: from [127.0.1.1] (RED-LION-HO.car2.Seattle1.Level3.net. [4.53.155.98]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0976ca5f9sm1331613a91.14.2026.09.23.16.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 16:57:07 -0700 (PDT) From: Tal Zussman Date: Wed, 23 Sep 2026 19:56:42 -0400 Subject: [PATCH v5 9/9] block: remove dead metadata handling from the async direct I/O path Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260923-blkdev-fixes-v5-9-89e60d66eb38@columbia.edu> References: <20260923-blkdev-fixes-v5-0-89e60d66eb38@columbia.edu> In-Reply-To: <20260923-blkdev-fixes-v5-0-89e60d66eb38@columbia.edu> To: Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Luis Chamberlain , Hannes Reinecke , "Matthew Wilcox (Oracle)" , John Garry , Christian Brauner , "Darrick J. Wong" , Keith Busch , "Martin K. Petersen" Cc: Shin'ichiro Kawasaki , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.17-dev-db0b7 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790207813; l=1396; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=YMDQDXgHvisSOsY3WQrY2kVt6FOq3O9Ypoh2P+vxzKE=; b=sPILe/kyUbp0UCL4bz6D402nDcKVbwLmg2pPSjHxEY9K3xV0BuZybj9/lGnB5Pvf23U4M1YB2 0anpPrFDTkYCwMc6vi4Kax3gcCsgrwudHvLW7rNxmggYFs8LnnxxPGg X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-ORIG-GUID: ufDfvrQcqERPngqLwUUCkGRZK5DFH_fw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDEwMCBTYWx0ZWRfX0HfVxWvx+Ik4 EkxBZ+O/RAeHPf+YDsIgrlXpGSViVnMHskgoh62tZUFeIX20rgCSw172QxvVUdsgkRBklzdKaio cpdK5UEWoY7DRlGsRdwcM5jkSgl4o3jfTES5+A8rolxC8J3iJDD0LGujBued9eN53vbrMcPRMKx GrrO2AU4JuJNb2BEtkTTHeZQ9kOUTu8/QGvCdHSjVPPxcPZ2Ecr0B3W21X282iql1IIJU1F2e1/ Ai2uUeKgrGLsH0ZosNhBoZgMsodgC5GY16Lef5GqqoqmR2mUy3cgzFCh3ZT+P5igZ74qYx7fBhR DLpI9dSTyV31UFUE7MBpqhfUVSi5CtEIFUr9poCOsdIGRvX9CTXYLkw3vQ6Ir5vkr9gucjhFUy4 /xhY0EX9Xz8rygGV3pDsOKzNf8Xnawa5I67YgThf9m7m1a2o7BQG41VY1tOwbM27aapyOofHXre kT30hzltXlOGyTU1vdw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDEwMCBTYWx0ZWRfX5yNvr76Lyehm 70LN9fEv+dk2PqyLBGikM9z7sF13YNm9skO5NBy9aAJmypA6+2i523MkSfL6XiiiBYDAsJr5vpy sP7FcrVKxne4VfKJhC6DAexVQ09+wDVAdz343MBc5Lag1FNmivUO X-Authority-Analysis: v=2.4 cv=J/A/fwnS c=1 sm=1 tr=0 ts=6ab46755 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=6aZ3Ysb2zzbY2sELL/OBJw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=x7bEGLp0ZPQA:10 a=A0y_DWxS2BwA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=JR4YdQiviy7OQf72WyZ1:22 a=VwQbUJbxAAAA:8 a=IE87Obj3e0A1gCLlgTsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: ufDfvrQcqERPngqLwUUCkGRZK5DFH_fw X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11914 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=10 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=10 bulkscore=10 spamscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230100 Since commit 2729a60bbfb9 ("block: don't silently ignore metadata for sync read/write"), blkdev_direct_IO() sends every IOCB_HAS_METADATA request to __blkdev_direct_IO(). Remove the now unreachable metadata mapping in __blkdev_direct_IO_async() and the unmap in its completion handler. No functional change. Assisted-by: Claude:claude-fable-5 Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Signed-off-by: Tal Zussman --- block/fops.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/block/fops.c b/block/fops.c index 59af4e808204..b13e8f83ff82 100644 --- a/block/fops.c +++ b/block/fops.c @@ -306,9 +306,6 @@ static void blkdev_bio_end_io_async(struct bio *bio) ret = blk_status_to_errno(bio->bi_status); } - if (bio_integrity(bio)) - bio_integrity_unmap_user(bio); - iocb->ki_complete(iocb, ret); if (dio->flags & DIO_SHOULD_DIRTY) { @@ -370,13 +367,6 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb, task_io_account_write(bio->bi_iter.bi_size); } - if (iocb->ki_flags & IOCB_HAS_METADATA) { - ret = bio_integrity_map_iter(bio, iocb->private); - WRITE_ONCE(iocb->private, NULL); - if (unlikely(ret)) - goto out_bio_put; - } - if (iocb->ki_flags & IOCB_HIPRI) { bio->bi_opf |= REQ_POLLED; submit_bio(bio); -- 2.39.5