Re: [PATCH 6/9] xfs: lift setting the NOFS context to xfs_end_io

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Sep 24, 2026 at 11:57:07AM +0200, Christoph Hellwig wrote:
> No point in clearing and restoring it for every processed bio.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Agreed.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_ioend.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/xfs/xfs_ioend.c b/fs/xfs/xfs_ioend.c
> index e70be5b86f0b..258c6130bee8 100644
> --- a/fs/xfs/xfs_ioend.c
> +++ b/fs/xfs/xfs_ioend.c
> @@ -175,16 +175,8 @@ xfs_end_ioend_write(
>  	bool			is_zoned = xfs_is_zoned_inode(ip);
>  	xfs_off_t		offset = ioend->io_offset;
>  	size_t			size = ioend->io_size;
> -	unsigned int		nofs_flag;
>  	int			error;
>  
> -	/*
> -	 * We can allocate memory here while doing writeback on behalf of
> -	 * memory reclaim.  To avoid memory allocation deadlocks set the
> -	 * task-wide nofs context for the following operations.
> -	 */
> -	nofs_flag = memalloc_nofs_save();
> -
>  	/*
>  	 * Just clean up the in-memory structures if the fs has been shut down.
>  	 */
> @@ -241,7 +233,6 @@ xfs_end_ioend_write(
>  	if (is_zoned)
>  		xfs_ioend_put_open_zones(ioend);
>  	iomap_finish_ioends(ioend, error);
> -	memalloc_nofs_restore(nofs_flag);
>  }
>  
>  /*
> @@ -266,6 +257,7 @@ xfs_end_io(
>  		container_of(work, struct xfs_inode, i_ioend_work);
>  	struct iomap_ioend	*ioend;
>  	struct list_head	tmp;
> +	unsigned int		nofs_flag;
>  	unsigned long		flags;
>  
>  	spin_lock_irqsave(&ip->i_ioend_lock, flags);
> @@ -273,6 +265,13 @@ xfs_end_io(
>  	spin_unlock_irqrestore(&ip->i_ioend_lock, flags);
>  
>  	iomap_sort_ioends(&tmp);
> +
> +	/*
> +	 * We can allocate memory here while doing writeback on behalf of
> +	 * memory reclaim.  To avoid memory allocation deadlocks set the
> +	 * task-wide nofs context for the following operations.
> +	 */
> +	nofs_flag = memalloc_nofs_save();
>  	while ((ioend = list_first_entry_or_null(&tmp, struct iomap_ioend,
>  			io_list))) {
>  		list_del_init(&ioend->io_list);
> @@ -280,6 +279,7 @@ xfs_end_io(
>  		xfs_end_ioend_write(ioend);
>  		cond_resched();
>  	}
> +	memalloc_nofs_restore(nofs_flag);
>  }
>  
>  void
> -- 
> 2.53.0
> 
>