Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: djwong@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: test libxfs handling of missing RT devices
Date: Mon, 28 Sep 2026 07:35:27 +0200	[thread overview]
Message-ID: <20260928053527.GA19314@lst.de> (raw)
In-Reply-To: <arkF56Qtd-kQS9jH@zlang-mailbox>

On Sun, Sep 27, 2026 at 08:20:12PM +0800, Zorro Lang wrote:
> > +_require_scratch_nocheck
> > +_require_realtime
> > +
> > +if [ -z "$SCRATCH_RTDEV" ]; then
> > +	_notrun "external RT device required"
> > +fi
> 
> I think "_require_realtime -> _require_external_realtime_device" already covers
> the "_notrun" above. I'll help to remove above redundant code when merging.

Yeah, _require_external_realtime_device would be better here.


  reply	other threads:[~2026-09-28  5:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25  5:15 [PATCH] xfs: test libxfs handling of missing RT devices Christoph Hellwig
2026-09-25 19:47 ` Darrick J. Wong
2026-09-27 12:20 ` Zorro Lang
2026-09-28  5:35   ` Christoph Hellwig [this message]
2026-09-28  6:58   ` Christoph Hellwig
2026-09-28  9:56     ` Zorro Lang
  -- strict thread matches above, loose matches on Subject: below --
2026-09-14 11:36 Christoph Hellwig
2026-09-14 15:05 ` Darrick J. Wong
2026-09-15  6:22   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928053527.GA19314@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox