Re: [PATCH 2/3] iomap: use bio_complete_in_task for buffered write failures

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Sep 28, 2026 at 11:11:08AM +0200, Christoph Hellwig wrote:
> Use bio_complete_in_task to defer the bio completion handler to task
> context instead of the homegrown deferral.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks about the same as the previous conversion, so
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/iomap/ioend.c | 48 ++----------------------------------------------
>  1 file changed, 2 insertions(+), 46 deletions(-)
> 
> diff --git a/fs/iomap/ioend.c b/fs/iomap/ioend.c
> index 7bbbb417f915..1c8840bde1ff 100644
> --- a/fs/iomap/ioend.c
> +++ b/fs/iomap/ioend.c
> @@ -74,57 +74,13 @@ static u32 iomap_finish_ioend_buffered_write(struct iomap_ioend *ioend)
>  	return folio_count;
>  }
>  
> -static DEFINE_SPINLOCK(failed_ioend_lock);
> -static LIST_HEAD(failed_ioend_list);
> -
> -static void
> -iomap_fail_ioends(
> -	struct work_struct	*work)
> -{
> -	struct iomap_ioend	*ioend;
> -	struct list_head	tmp;
> -	unsigned long		flags;
> -
> -	spin_lock_irqsave(&failed_ioend_lock, flags);
> -	list_replace_init(&failed_ioend_list, &tmp);
> -	spin_unlock_irqrestore(&failed_ioend_lock, flags);
> -
> -	while ((ioend = list_first_entry_or_null(&tmp, struct iomap_ioend,
> -			io_list))) {
> -		list_del_init(&ioend->io_list);
> -		iomap_finish_ioend_buffered_write(ioend);
> -		cond_resched();
> -	}
> -}
> -
> -static DECLARE_WORK(failed_ioend_work, iomap_fail_ioends);
> -
> -static void iomap_fail_ioend_buffered(struct iomap_ioend *ioend)
> -{
> -	unsigned long flags;
> -
> -	/*
> -	 * Bounce I/O errors to a workqueue to avoid nested i_lock acquisitions
> -	 * in the fserror code.  The caller no longer owns the ioend reference
> -	 * after the spinlock drops.
> -	 */
> -	spin_lock_irqsave(&failed_ioend_lock, flags);
> -	if (list_empty(&failed_ioend_list))
> -		WARN_ON_ONCE(!schedule_work(&failed_ioend_work));
> -	list_add_tail(&ioend->io_list, &failed_ioend_list);
> -	spin_unlock_irqrestore(&failed_ioend_lock, flags);
> -}
> -
>  static void ioend_writeback_end_bio(struct bio *bio)
>  {
>  	struct iomap_ioend *ioend = iomap_ioend_from_bio(bio);
>  
> -	ioend->io_error = blk_status_to_errno(bio->bi_status);
> -	if (ioend->io_error) {
> -		iomap_fail_ioend_buffered(ioend);
> +	if (bio->bi_status && bio_complete_in_task(bio))
>  		return;
> -	}
> -
> +	ioend->io_error = blk_status_to_errno(bio->bi_status);
>  	iomap_finish_ioend_buffered_write(ioend);
>  }
>  
> -- 
> 2.53.0
>