Re: [PATCH 2/8] xfs: remove redundant stat checks after xfs_refcount_insert()

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Oct 16, 2026 at 02:29:02PM -0500, Eric Sandeen wrote:
> xfs_refcount_insert() simply returns the error and status from
> xfs_btree_insert, which has already validated the insert or returned
> an error.
> 
> This makes every instance of the 2nd test in this idiom:
> 
> 	if ((error = xfs_refcount_insert(cnt_cur, &i)))
> 		return error;
> 	if (XFS_IS_CORRUPT(mp, i != 1)) {
> 		xfs_btree_mark_sick(cnt_cur);
> 		return -EFSCORRUPTED;
> 	}
> 
> unnecessary/unreachable code. Remove them.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_refcount.c | 19 ++-----------------
>  1 file changed, 2 insertions(+), 17 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
> index 49e9993ce360..aec6c839220a 100644
> --- a/fs/xfs/libxfs/xfs_refcount.c
> +++ b/fs/xfs/libxfs/xfs_refcount.c
> @@ -457,12 +457,8 @@ xfs_refcount_split_extent(
>  	error = xfs_refcount_insert(cur, &tmp, &found_rec);
>  	if (error)
>  		goto out_error;
> -	if (XFS_IS_CORRUPT(cur->bc_mp, found_rec != 1)) {
> -		xfs_btree_mark_sick(cur);
> -		error = -EFSCORRUPTED;
> -		goto out_error;
> -	}
> -	return error;
> +
> +	return 0;
>  
>  out_error:
>  	trace_xfs_refcount_split_extent_error(cur, error, _RET_IP_);
> @@ -1191,12 +1187,6 @@ xfs_refcount_adjust_extents(
>  						&found_tmp);
>  				if (error)
>  					goto out_error;
> -				if (XFS_IS_CORRUPT(cur->bc_mp,
> -						   found_tmp != 1)) {
> -					xfs_btree_mark_sick(cur);
> -					error = -EFSCORRUPTED;
> -					goto out_error;
> -				}
>  			} else {
>  				error = xrefc_free_extent(cur, &tmp);
>  				if (error)
> @@ -1841,11 +1831,6 @@ xfs_refcount_adjust_cow_extents(
>  				&found_tmp);
>  		if (error)
>  			goto out_error;
> -		if (XFS_IS_CORRUPT(cur->bc_mp, found_tmp != 1)) {
> -			xfs_btree_mark_sick(cur);
> -			error = -EFSCORRUPTED;
> -			goto out_error;
> -		}
>  		break;
>  	case XFS_REFCOUNT_ADJUST_COW_FREE:
>  		/* Removing a CoW reservation, there should be one extent. */
> -- 
> 2.55.0
> 
>