From: Joanne Koong <joannelkoong@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <djwong@kernel.org>,
changfengnan@bytedance.com, kbusch@kernel.org,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jonathan Corbet <corbet@lwn.net>, David Sterba <dsterba@suse.com>,
Gao Xiang <xiang@kernel.org>, Namjae Jeon <linkinjeon@kernel.org>,
Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Andreas Gruenbacher <agruenba@redhat.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Hyunchul Lee <hyc.lee@gmail.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Carlos Maiolino <cem@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
libaokun@linux.alibaba.com, bfoster@redhat.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
Viacheslav Dubeyko <slava@dubeyko.com>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
linux-nilfs@vger.kernel.org, fuse-devel@lists.linux.dev,
Zhang Yi <yi.zhang@huawei.com>
Subject: [PATCH 3/5] iomap: remove ->iomap_begin()/->iomap_end() legacy path
Date: Tue, 27 Oct 2026 14:53:24 -0700 [thread overview]
Message-ID: <20261027215326.2693300-4-joannelkoong@gmail.com> (raw)
In-Reply-To: <20261027215326.2693300-1-joannelkoong@gmail.com>
With all in-tree filesystems implementing ->iomap_next(), drop the
->iomap_begin()/->iomap_end() path.
Reviewed-by: Fengnan Chang <changfengnan@bytedance.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
fs/iomap/iter.c | 6 +-----
include/linux/iomap.h | 6 ++----
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c
index fd8791c4963b..8b6da9750a93 100644
--- a/fs/iomap/iter.c
+++ b/fs/iomap/iter.c
@@ -119,11 +119,7 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)
trace_iomap_iter(iter, ops, _RET_IP_);
- if (ops->iomap_next)
- ret = ops->iomap_next(iter, &iter->iomap, &iter->srcmap);
- else
- ret = iomap_iter_next(iter, &iter->iomap, &iter->srcmap,
- ops->iomap_begin, ops->iomap_end);
+ ret = ops->iomap_next(iter, &iter->iomap, &iter->srcmap);
iter->status = 0;
if (ret > 0)
diff --git a/include/linux/iomap.h b/include/linux/iomap.h
index 59718f73c15a..95d4995a49ca 100644
--- a/include/linux/iomap.h
+++ b/include/linux/iomap.h
@@ -195,7 +195,7 @@ struct iomap_write_ops {
};
/*
- * Flags for iomap_begin / iomap_end. No flag implies a read.
+ * Flags for iomap_next. No flag implies a read.
*/
#define IOMAP_WRITE (1 << 0) /* writing, must allocate blocks */
#define IOMAP_ZERO (1 << 1) /* zeroing operation, may skip holes */
@@ -240,8 +240,6 @@ typedef int (*iomap_iter_next_fn)(const struct iomap_iter *iter,
struct iomap *iomap, struct iomap *srcmap);
struct iomap_ops {
- iomap_iter_begin_fn iomap_begin;
- iomap_iter_end_fn iomap_end;
iomap_iter_next_fn iomap_next;
};
@@ -256,7 +254,7 @@ struct iomap_ops {
* incremental iter advance.
* @status: Status of the most recent iteration. Zero on success or a negative
* errno on error.
- * @flags: Zero or more of the iomap_begin flags above.
+ * @flags: Zero or more of the iomap_next flags above.
* @iomap: Map describing the I/O iteration
* @srcmap: Source map for COW operations
*/
--
2.52.0
next prev parent reply other threads:[~2026-10-27 21:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 21:53 [PATCH 0/5] iomap: remaining patches for iomap_iter_next conversion Joanne Koong
2026-10-27 21:53 ` [PATCH 1/5] nilfs2: convert iomap ops to ->iomap_next() Joanne Koong
2026-10-28 15:00 ` Christoph Hellwig
2026-10-28 16:17 ` Ryusuke Konishi
2026-10-27 21:53 ` [PATCH 2/5] fuse: convert ext_map " Joanne Koong
2026-10-28 15:01 ` Christoph Hellwig
2026-10-27 21:53 ` Joanne Koong [this message]
2026-10-27 21:53 ` [PATCH 4/5] iomap: pass iomap_iter_next_fn directly instead of struct iomap_ops Joanne Koong
2026-10-27 21:53 ` [PATCH 5/5] Documentation: iomap: update docs to reflect iomap_iter_next model Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027215326.2693300-4-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=agruenba@redhat.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=changfengnan@bytedance.com \
--cc=corbet@lwn.net \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=fuse-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=hyc.lee@gmail.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kbusch@kernel.org \
--cc=konishi.ryusuke@gmail.com \
--cc=libaokun@linux.alibaba.com \
--cc=linkinjeon@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=slava@dubeyko.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox