From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfsprogs: add gcc generated stack usage files to gitignore
Date: Tue, 3 Nov 2026 10:46:21 +0100 [thread overview]
Message-ID: <20261103094621.GA6108@lst.de> (raw)
In-Reply-To: <aumm86mEWhMUfNtL@aalbersh-thinkpadx1carbongen13.rmtcz.csb>
On Tue, Nov 03, 2026 at 10:25:39AM +0100, Andrey Albershteyn wrote:
> On 2026-11-03 06:44:11, Christoph Hellwig wrote:
> > On Thu, Oct 29, 2026 at 05:10:23PM +0100, Andrey Albershteyn wrote:
> > > These are generated by gcc due to recently added:
> > >
> > > WARNINGS += -fstack-usage
> >
> > I don't actually see that added, and I also think we really should not
> > add it by default.
>
> Yes it's not set yet, I meant to reference Darrick's patches with
> Warnings [1]. I thought your patchset is also a preparation for pulling
> those warnings. I can resend Darrick's patchset without stack-usage,
> I will look if all of those are necessary actually
I think a lot of them are over the top. A good first step would be
to catch up with the kernel flags.
next prev parent reply other threads:[~2026-11-03 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 16:10 [PATCH 0/2] xfsprogs: warning fix and add stack usage to gitignore Andrey Albershteyn
2026-10-29 16:10 ` [PATCH 1/2] xfs: fix two warnings in xfs_alloc.c Andrey Albershteyn
2026-11-03 5:43 ` Christoph Hellwig
2026-10-29 16:10 ` [PATCH 2/2] xfsprogs: add gcc generated stack usage files to gitignore Andrey Albershteyn
2026-11-03 5:44 ` Christoph Hellwig
2026-11-03 9:25 ` Andrey Albershteyn
2026-11-03 9:46 ` Christoph Hellwig [this message]
2026-11-02 13:13 ` [PATCH 0/2] xfsprogs: warning fix and add stack usage " Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103094621.GA6108@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox