Re: [PATCH] xfs: test that statfs does not report negative free blocks

[Christoph Hellwig <hch@lst.de>]

On Thu, Nov 12, 2026 at 12:33:03PM -0500, Hengyu Liang wrote:
> On Thu, Nov 12, 2026 at 04:53:31PM +0100, Christoph Hellwig wrote:
> > On Thu, Nov 12, 2026 at 10:49:17AM -0500, Hengyu Liang wrote:
> > > +# Only the data device counters are checked.
> > > +_disable_scratch_realtime
> > > +
> > > +_scratch_mkfs >> $seqres.full 2>&1
> > > +_scratch_mount
> > > +_require_xfs_scratch_non_zoned
> > 
> > Why do you need _require_xfs_scratch_non_zoned?  If this test is always
> > working on the data volume due to disable_scratch_realtime above,
> > a zoned vs non-zoned RT volume shouldn't matter unless I'm missing
> > something.
> 
> I copied it from xfs/306. _disable_scratch_realtime only unsets
> SCRATCH_RTDEV and removes "-r zoned=1" from MKFS_OPTIONS. When
> SCRATCH_DEV itself is a zoned device, mkfs still creates an internal
> zoned RT section, and the root directory has rtinherit set, so the
> files are created on the RT section. I tried this on a zoned null_blk
> device without the check: all the fallocate calls fail with EOPNOTSUPP,
> statfs on the mount point reports the RT counters, and the test fails
> with and without the fix.

Oh, ok. 

Looks good then:

Reviewed-by: Christoph Hellwig <hch@lst.de>