Re: [PATCH] xfs: fix number of GC bvecs

[Damien Le Moal <dlemoal@kernel.org>]

On 4/1/26 22:58, Christoph Hellwig wrote:
> GC scratch allocations can wrap around and use the same buffer twice, and
> the current code fails to account for that.  So far this worked due to
> rounding in the block layer, but changes to the bio allocator drop the
> over-provisioning and generic/256 or generic/361 will not usually fail
> when running against the current block tree.
> 
> Simply the allocation to always pass the maximum value that is easier to

s/Simply/Simplify

> verify, as a saving of up to one bvec per allocation isn't worth the
> effort to verify a complicated calculated value.
> 
> Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management")
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research