From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:50776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933334AbdCaPv2 (ORCPT ); Fri, 31 Mar 2017 11:51:28 -0400 From: David Howells In-Reply-To: <20170331154315.GB29622@ZenIV.linux.org.uk> References: <20170331154315.GB29622@ZenIV.linux.org.uk> <20170311065823.4415-1-ebiggers3@gmail.com> <20170320171142.GA26906@gmail.com> <20170320174422.GA9304@infradead.org> <20170331153952.GA32460@infradead.org> Subject: Re: [PATCH] statx: reject unknown flags when using NULL path MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21300.1490975484.1@warthog.procyon.org.uk> Date: Fri, 31 Mar 2017 16:51:24 +0100 Message-ID: <21301.1490975484@warthog.procyon.org.uk> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Al Viro Cc: dhowells@redhat.com, Christoph Hellwig , Eric Biggers , linux-fsdevel@vger.kernel.org, mtk.manpages@gmail.com, "Darrick J . Wong" , Linux API , linux-xfs@vger.kernel.org, Eric Biggers Al Viro wrote: > > can we get this in please? It would be sad to grow another syscall > > with an unchecked flags argument.. > > Applied, will be in tonight pull request... I'm not convinced that this is right. I'm more inclined to let any flag be passed that is available to statx() with a filename and just mask off the bits before handing them on. David