Re: [PATCH v11 2/2] xfs: add FALLOC_FL_WRITE_ZEROES to XFS code base

[Pankaj Raghav <pankaj.raghav@linux.dev>]

>>> So, a helper function in fs/xfs/xfs_bmap_util.c such as this:
>>>
>>> /*
>>>  * This function is used to allocate written extents over holes
>>>  * and/or convert unwritten extents to written extents based on the
>>>  * @flags passed to it.
>>>  *
>>>  * If @flags is zero, if will allocate written extents for holes and
>>
>> s/zero/XFS_BMAPI_ZERO ?
> 
> No, I explicitly meant flags = 0.
> 
>>>  * delalloc extents across the range.
>>>  *
>>>  * If XFS_BMAPI_CONVERT is specified in @flags, then it will also do
>>>  * conversion of unwritten extents in the range to written extents.
>>>  *
>>>  * If XFS_BMAPI_ZERO is specified in @flags, then both newly
>>
>> s/XFS_BMAPI_ZERO/(XFS_BMAPI_ZERO | XFS_BMAPI_CONVERT) ?
> 
> No I explictly describing what happens when you do "flags |=
> XFS_BMAPI_ZERO;" to any other xfs_bmapi_write() operation
> flag specification.
> 
> i.e. XFS_BMAPI_ZERO is an optional behavioural modifier for
> allocation and/or unwritten extent conversion operations. i.e all it
> does is add initialisation of the new/modified extents to contain
> real zeroes.
> 
> e.g. flags = 0 means "allocate holes/delalloc as uninitialised
> written extents". flags = 0 | XFS_BMAPI_ZERO
> means "allocate holes/delalloc and initialise them to contain
> zeros". Unwritten extents will not be modified by either operation.
> 

Ok, Thanks for the clarification. I was about to send the patches.
I will make this change and send the patches.

--
Pankaj