Re: Review: xfsprogs with libblkid enabled for Debian

Christoph Hellwig
2010-08-19T12:11:23Z

On Wed, Aug 18, 2010 at 03:06:28PM +1000, nathans@aconex.com wrote:
> Hi guys,
>
> Attached patch adds support for libblkid in Debian builds.
> There's a couple of other trivial things fixed up while the
> package was building - man page typos reported by lintian,
> fix source tarball generation (and deb build) when libblkid
> is enabled (*must* descend into libdisk to pick up sources)
> ... but its all pretty straight forward.
>
> I've checked that mkfs.xfs is linked as expected too. :)

All the changes in here look good, but I'd be much happier if you'd
submit separate changes with separate changelogs for the manpage
updates and the libdisk packaging fix.

As for the blkid-dev build-dep: we need at least version 2.17 of it
as that introduced the symbols we need, I think a versioned dependency
for this would be in order.

The doc/CHANGES update should include the names of external contributors
where applicable, and currently the release date for is set as part
of the release.sh process.

I'm fine with pushing out a new 3.1.3 release as it's time anyway, but
can we also include Dave's patch to add XFS_IOC_ZERO_RANGE support to
xfs_io and the xfsctl manpage first?

Next week also has Alex back from vacation, so I'd suggest waiting if
he has any input on this.