From: Chandan Babu R <chandanrlinux@gmail.com>
To: guaneryu@gmail.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
darrick.wong@oracle.com, zlang@redhat.com
Subject: Re: [PATCH V2 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type
Date: Wed, 16 Sep 2020 18:41:55 +0530 [thread overview]
Message-ID: <2438001.59BAfK7u84@garuda> (raw)
In-Reply-To: <20200916053407.2036-2-chandanrlinux@gmail.com>
On Wednesday 16 September 2020 11:04:07 AM IST Chandan Babu R wrote:
> This commit adds a test to check if growing a real-time device can end
> up logging an xfs_buf with the "type" subfield of
> bip->bli_formats->blf_flags set to XFS_BLFT_UNKNOWN_BUF. When this
> occurs the following call trace is printed on the console,
>
> XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 331
> Call Trace:
> xfs_buf_item_format+0x632/0x680
> ? kmem_alloc_large+0x29/0x90
> ? kmem_alloc+0x70/0x120
> ? xfs_log_commit_cil+0x132/0x940
> xfs_log_commit_cil+0x26f/0x940
> ? xfs_buf_item_init+0x1ad/0x240
> ? xfs_growfs_rt_alloc+0x1fc/0x280
> __xfs_trans_commit+0xac/0x370
> xfs_growfs_rt_alloc+0x1fc/0x280
> xfs_growfs_rt+0x1a0/0x5e0
> xfs_file_ioctl+0x3fd/0xc70
> ? selinux_file_ioctl+0x174/0x220
> ksys_ioctl+0x87/0xc0
> __x64_sys_ioctl+0x16/0x20
> do_syscall_64+0x3e/0x70
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> The kernel patch "xfs: Set xfs_buf type flag when growing summary/bitmap
> files" is required to fix this issue.
>
Eryu,
Sorry, I forgot to add Darrick's RVB tag. Please let me know if I have to
resend the patch with the missing RVB.
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
--
chandan
next prev parent reply other threads:[~2020-09-16 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 5:34 [PATCH 1/2] xfs: Add realtime group Chandan Babu R
2020-09-16 5:34 ` [PATCH V2 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type Chandan Babu R
2020-09-16 13:11 ` Chandan Babu R [this message]
2020-09-16 16:53 ` Darrick J. Wong
2020-09-17 3:50 ` Chandan Babu R
2020-09-16 16:51 ` [PATCH 1/2] xfs: Add realtime group Darrick J. Wong
2020-09-17 4:10 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2438001.59BAfK7u84@garuda \
--to=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox