Re: [PATCH] xfs_repair: junk leaf attribute if count == 0

["Libor Klepáč" <libor.klepac@bcom.cz>]

Hi,
On středa 15. března 2017 10:22:05 CET Eric Sandeen wrote:
> On 3/15/17 5:07 AM, Libor Klepáč wrote:
> > Hello,
> 
> ...
> 
> >> Unfortunately the read path is a bit less interesting.  We found something
> >> on disk, but we're not sure how it got there.
> >> If we could catch a write verifier failing that /might/ be a little more
> >> useful.
> > 
> > I'm prepared to run all affected hosts with error_level=11 , if it doesn't mean performance hit.
> 
> It shouldn't.  It only changes logging behavior on error.  The printks to the
> console probably take a bit of extra time but at that point you've already lost,
> right?

Ok, thanks for clarification, I was wondering whether higher error_level isn't triggering some extra code paths during normal operation.
I will leave it on 11 on all machines with problems.

Btw. i naively created 
/etc/sysctl.d/fs_xfs_error_level.conf
with 
fs.xfs.error_level=11
inside.
But it's not set after reboot. May it be because XFS module (not root filesystem) is loaded after sysctl is set?

Bellow is result of repair.
I was expecting 
bad attribute count 0 in attr block 0, inode 2152616264
to be
bad attribute count 0 in attr block 0x24e70268, inode 2152616264

Function process_leaf_attr_block should be called with non-zero da_bno in process_leaf_attr_level , right?
But it's called with da_bno = 0 in process_longform_attr .

Of course I don't know the code.

Libor

# xfs_repair  /dev/mapper/vgDisk2-lvData
Phase 1 - find and verify superblock...
Phase 2 - using internal log
        - zero log...
        - scan filesystem freespace and inode maps...
        - found root inode chunk
Phase 3 - for each AG...
        - scan and clear agi unlinked lists...
        - process known inodes and perform inode discovery...
        - agno = 0
        - agno = 1
        - agno = 2
bad attribute count 0 in attr block 0, inode 2152616264
problem with attribute contents in inode 2152616264
clearing inode 2152616264 attributes
correcting nblocks for inode 2152616264, was 1 - counted 0
        - process newly discovered inodes...
Phase 4 - check for duplicate blocks...
        - setting up duplicate extent list...
        - check for inodes claiming duplicate blocks...
        - agno = 0
        - agno = 1
        - agno = 2
bad attribute format 1 in inode 2152616264, resetting value
Phase 5 - rebuild AG headers and trees...
        - reset superblock...
Phase 6 - check inode connectivity...
        - resetting contents of realtime bitmap and summary inodes
        - traversing filesystem ...
        - traversal finished ...
        - moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
Done