Re: [PATCH 3/4] block: add a bio_submit_or_kill helper

[Damien Le Moal <dlemoal@kernel.org>]

On 2026/04/06 7:57, Christoph Hellwig wrote:
> Factor the common logic for the ioctl helpers to either submit a bio or
> end if the process is being killed.  As this is now the only user of
> bio_await_chain, open code that.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me. Just one comment below.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

> ---
>  block/bio.c     | 23 ++++++++++++++---------
>  block/blk-lib.c | 16 ++--------------
>  block/blk.h     |  2 +-
>  block/ioctl.c   | 11 ++---------
>  4 files changed, 19 insertions(+), 33 deletions(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index c7e75d532666..994db354439f 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1520,6 +1520,20 @@ static void bio_endio_cb(struct bio *bio, void *priv)
>  	bio_endio(bio);
>  }
>  
> +/*
> + * Submit @bio synchronously, or call bio_endio on it if the current process
> + * is being killed.
> + */
> +int bio_submit_or_kill(struct bio *bio, unsigned int flags)
> +{
> +	if ((flags & BLKDEV_ZERO_KILLABLE) && fatal_signal_pending(current)) {
> +		bio_await(bio, NULL, bio_endio_cb);
> +		return -EINTR;

This was like this in the previous code, so not big deal, but should we perhaps
return the bio error if there was one ? And return -EINTR if there was no error.


-- 
Damien Le Moal
Western Digital Research