From: John Garry <john.g.garry@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org,
catherine.hoang@oracle.com
Subject: Re: [PATCH 4/7] mkfs: don't complain about overly large auto-detected log stripe units
Date: Tue, 8 Jul 2025 16:07:40 +0100 [thread overview]
Message-ID: <2ddf1d9a-6d04-48b5-be73-99f2bc3fbddc@oracle.com> (raw)
In-Reply-To: <20250708150526.GD2672070@frogsfrogsfrogs>
On 08/07/2025 16:05, Darrick J. Wong wrote:
> On Tue, Jul 08, 2025 at 03:38:10PM +0100, John Garry wrote:
>> On 01/07/2025 19:07, Darrick J. Wong wrote:
>>> From: Darrick J. Wong<djwong@kernel.org>
>>>
>>> If mkfs declines to apply what it thinks is an overly large data device
>>> stripe unit to the log device, it should only log a message about that
>>> if the lsunit parameter was actually supplied by the caller. It should
>>> not do that when the lsunit was autodetected from the block devices.
>>>
>>> The cli parameters are zero-initialized in main and always have been.
>>>
>>> Cc:<linux-xfs@vger.kernel.org> # v4.15.0
>>> Fixes: 2f44b1b0e5adc4 ("mkfs: rework stripe calculations")
>>> Signed-off-by: "Darrick J. Wong"<djwong@kernel.org>
>>
>> Makes sense, so FWIW:
>>
>> John Garry <john.g.garry@oracle.com>
>
> Um.... is this a Reviewed-by: ?
oops, yes:
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2025-07-08 15:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 18:03 [PATCHBOMB] xfsprogs: ports and new code for 6.16 Darrick J. Wong
2025-07-01 18:04 ` [PATCHSET 1/3] xfsprogs: new libxfs code from kernel 6.16 Darrick J. Wong
2025-07-01 18:05 ` [PATCH 1/6] xfs: add helpers to compute transaction reservation for finishing intent items Darrick J. Wong
2025-07-01 18:05 ` [PATCH 2/6] xfs: allow block allocator to take an alignment hint Darrick J. Wong
2025-07-01 18:06 ` [PATCH 3/6] xfs: commit CoW-based atomic writes atomically Darrick J. Wong
2025-07-01 18:06 ` [PATCH 4/6] libxfs: add helpers to compute log item overhead Darrick J. Wong
2025-07-01 18:06 ` [PATCH 5/6] xfs: add xfs_calc_atomic_write_unit_max() Darrick J. Wong
2025-07-01 18:06 ` [PATCH 6/6] xfs: allow sysadmins to specify a maximum atomic write limit at mount time Darrick J. Wong
2025-07-01 18:05 ` [PATCHSET 2/3] xfsprogs: atomic writes Darrick J. Wong
2025-07-01 18:07 ` [PATCH 1/7] libfrog: move statx.h from io/ to libfrog/ Darrick J. Wong
2025-07-02 9:13 ` John Garry
2025-07-01 18:07 ` [PATCH 2/7] xfs_db: create an untorn_max subcommand Darrick J. Wong
2025-07-09 15:39 ` John Garry
2025-07-09 16:35 ` Darrick J. Wong
2025-07-01 18:07 ` [PATCH 3/7] xfs_io: dump new atomic_write_unit_max_opt statx field Darrick J. Wong
2025-07-02 8:23 ` John Garry
2025-07-01 18:07 ` [PATCH 4/7] mkfs: don't complain about overly large auto-detected log stripe units Darrick J. Wong
2025-07-08 14:38 ` John Garry
2025-07-08 15:05 ` Darrick J. Wong
2025-07-08 15:07 ` John Garry [this message]
2025-07-01 18:08 ` [PATCH 5/7] mkfs: autodetect log stripe unit for external log devices Darrick J. Wong
2025-07-09 15:57 ` John Garry
2025-07-09 16:45 ` Darrick J. Wong
2025-07-01 18:08 ` [PATCH 6/7] mkfs: try to align AG size based on atomic write capabilities Darrick J. Wong
2025-07-02 9:03 ` John Garry
2025-07-02 19:00 ` Darrick J. Wong
2025-07-01 18:08 ` [PATCH 7/7] mkfs: allow users to configure the desired maximum atomic write size Darrick J. Wong
2025-07-02 8:50 ` John Garry
2025-07-02 19:01 ` Darrick J. Wong
2025-07-01 18:05 ` [PATCHSET 3/3] xfs_scrub: drop EXPERIMENTAL warning Darrick J. Wong
2025-07-01 18:09 ` [PATCH 1/1] xfs_scrub: remove EXPERIMENTAL warnings Darrick J. Wong
2025-07-03 13:45 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2025-07-15 5:16 [PATCHSET 2/3] xfsprogs: atomic writes Darrick J. Wong
2025-07-15 5:18 ` [PATCH 4/7] mkfs: don't complain about overly large auto-detected log stripe units Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ddf1d9a-6d04-48b5-be73-99f2bc3fbddc@oracle.com \
--to=john.g.garry@oracle.com \
--cc=aalbersh@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).