Re: [PATCH v9 3/8] block: Add bdev atomic write limits helpers

John Garry
2024-10-16T12:37:00Z

On 16/10/2024 13:29, Christoph Hellwig wrote:
> On Wed, Oct 16, 2024 at 10:03:20AM +0000, John Garry wrote:
>> +static inline unsigned int
>> +bdev_atomic_write_unit_min_bytes(struct block_device *bdev)
>> +{
>> + if (!bdev_can_atomic_write(bdev))
>> + return 0;
>
> Aren't the limits always zero when the block device doesn't support
> atomic writes and we can skip these checks?

Not necessarily. bdev_can_atomic_write() has the partition alignment
checks also.

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>

thanks, but let me know if you would still like to see any changes.