Re: [PATCH V2 4/5] f2fs: ignore discard return value

Christoph Hellwig
2025-11-24T06:30:15Z

On Sun, Nov 23, 2025 at 06:57:36PM -0800, Chaitanya Kulkarni wrote:
> + __blkdev_issue_discard(bdev,
> + SECTOR_FROM_BLOCK(start),
> + SECTOR_FROM_BLOCK(len),
> + GFP_NOFS, &bio);

This can be shortened a bit as well:

__blkdev_issue_discard(bdev, SECTOR_FROM_BLOCK(start),
SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>