Re: [PATCH V2 2/5] dm: ignore discard return value

Damien Le Moal
2025-11-26T09:30:52Z

On 11/26/25 8:41 AM, Wilfred Mallawa wrote:
> On Sun, 2025-11-23 at 18:57 -0800, Chaitanya Kulkarni wrote:
>> __blkdev_issue_discard() always returns 0, making all error checking
>> at call sites dead code.
>>
>> For dm-thin change issue_discard() return type to void, in
>> passdown_double_checking_shared_status() remove the r assignment from
>> return value of the issue_discard(), for end_discard() hardcod value
>
> Hey Chaitanya,
>
> Typo here s/hardcod/hardcode. Otherwise, with the split as other have
> suggested:

s/hardcod/hardcoded

>
>
> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Regards,
> Wilfred
>

--
Damien Le Moal
Western Digital Research