From: Nathan Scott <nscott@aconex.com>
To: Christoph Hellwig <hch@infradead.org>,
Petr Salinger <Petr.Salinger@seznam.cz>,
agruen@suse.de
Cc: xfs@oss.sgi.com
Subject: Re: Bug#531950: attr: FTBFS on GNU/kFreeBSD
Date: Tue, 9 Jun 2009 20:31:33 +1000 (EST) [thread overview]
Message-ID: <364917872.6081221244543493694.JavaMail.root@mail-au.aconex.com> (raw)
In-Reply-To: <1450746396.6081061244543230576.JavaMail.root@mail-au.aconex.com>
----- "Christoph Hellwig" <hch@infradead.org> wrote:
> On Tue, Jun 09, 2009 at 10:03:28AM +1000, Nathan Scott wrote:
> > Could someone verify and merge this patch? It looks OK to
> > me.
>
> Andreas now takes care ot attr. Btw, the submitter should stop that
> stupid GNU wanking - errnos are defined by the kernel so it's a
> FreeBSD issues and has nothing to do with their glibc abuse.
Hmm, I'm not sure what you mean there. AIUI, this code
(strerror_ea) is working around Linux's lack of an ENOATTR
error code ... and on FreeBSD there really is an ENOATTR
(and no ENODATA?) Perhaps a better fix in this case may be
to map strerror_ea directly to strerror for all platforms
except Linux?
const char *strerror_ea(int err)
{
- if (err == ENODATA)
+ if (err == ENOATTR)
return _("No such attribute");
return strerror(err);
}
BTW, which git tree is the canonical acl/attr tree now Andreas?
Is it one of the kernel.org ones (which path?)? thanks.
cheers.
--
Nathan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2009-06-09 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1450746396.6081061244543230576.JavaMail.root@mail-au.aconex.com>
2009-06-09 10:31 ` Nathan Scott [this message]
2009-06-09 11:35 ` Bug#531950: attr: FTBFS on GNU/kFreeBSD Petr Salinger
2009-06-09 12:10 ` Christoph Hellwig
2009-06-14 16:35 ` Aurelien Jarno
2009-06-14 20:33 ` Christoph Hellwig
2009-06-14 20:56 ` Aurelien Jarno
2009-06-15 9:42 ` Christoph Hellwig
2009-06-15 10:26 ` Petr Salinger
2009-06-15 10:05 ` Aurelien Jarno
2009-06-19 15:37 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364917872.6081221244543493694.JavaMail.root@mail-au.aconex.com \
--to=nscott@aconex.com \
--cc=Petr.Salinger@seznam.cz \
--cc=agruen@suse.de \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox