From: Poyo VL <poyo_vl@yahoo.com>
To: aelder@sgi.com
Cc: xfs@oss.sgi.com
Subject: [PATCH] 2.6.35.4: Fixed simple warning (array subscript is above array bounds)
Date: Thu, 2 Sep 2010 02:10:26 -0700 (PDT) [thread overview]
Message-ID: <388312.90213.qm@web45811.mail.sp1.yahoo.com> (raw)
From: Ionut Gabriel Popescu <poyo_vl@yahoo.com>
When I tried to compile, I got the following warning:
fs/xfs/xfs_dir2_block.c: In function ‘xfs_dir2_sf_to_block’:
fs/xfs/xfs_dir2_block.c:1153:26: warning: array subscript is above array bounds
The code (fs/xfs/xfs_dir2_block.c line 1153) is:
dep->name[0] = dep->name[1] = '.';
dep is a pointer to a xfs_dir2_data_entry_t structure where name is defined as:
__u8 name[1]; /* name bytes, no null */
So it is a single element array, name[0] not also name[1] so I got that warning.
Patching is a simple replacement of 1 with 2.
Signed-off-by: Ionut Gabriel Popescu <poyo_vl@yahoo.com>
---
--- a/fs/xfs/xfs_dir2_data.h 2010-09-02 11:13:11.632007536 +0300
+++ b/fs/xfs/xfs_dir2_data.h 2010-09-02 11:13:28.080006488 +0300
@@ -87,7 +87,7 @@
typedef struct xfs_dir2_data_entry {
__be64 inumber; /* inode number */
__u8 namelen; /* name length */
- __u8 name[1]; /* name bytes, no null */
+ __u8 name[2]; /* name bytes, no null */
/* variable offset */
__be16 tag; /* starting offset of us */
} xfs_dir2_data_entry_t;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-09-02 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 9:10 Poyo VL [this message]
2010-09-16 16:42 ` [PATCH] 2.6.35.4: Fixed simple warning (array subscript is above array bounds) Alex Elder
2010-09-16 16:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=388312.90213.qm@web45811.mail.sp1.yahoo.com \
--to=poyo_vl@yahoo.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox