From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8FDAA1DFE39; Wed, 29 Jan 2025 17:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738170774; cv=none; b=rf5+8ZCTFwLPMqMplPi0wu/a3/ZDqZqYzgMk17ox/yl5jWVYF9h/OGf6Md5nOzy7T3EkWBghq1o+TdfeWm+zKbK2ggc7ThqiC/UM9Ktg2t2s+udNY6VuNUWrf54n2aOdPiFdgNYZQhZS9pIHt7BdgHZdJQrXoJMzRXx+Qh7+dFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738170774; c=relaxed/simple; bh=TFyB/uYYEaooUwj7hKVBSVMMFcH2VYfjBl67Cp84w0Q=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=E9hBwChJlMtMe6qB1+PJswZtpstuGRkRN3t7VKvGmLoGFMBwuD/zVgHchuepPezk9RlQd6IcTUxe5XIBFNQrbXDtRPcVc75qzV7sQw5zS8pHBZsOS+CUfxwM1H/FbBUV2cBCa5LRZ/q2kzwWeWGLZZxaXz/+/SULpc3KO4QxLxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=Rak3F2+8; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Rak3F2+8" Received: from [100.65.130.94] (unknown [20.236.11.69]) by linux.microsoft.com (Postfix) with ESMTPSA id AC3D420591A1; Wed, 29 Jan 2025 09:12:50 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AC3D420591A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738170772; bh=pYh2yn40lkpaqAG8En7hcsBez+8JKaFCGsBWiD832tE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Rak3F2+8fD36df/6R9W6FIe4vLPlHDgpiHFKAtGMBHH6D5mOcR2hxxoOHOyUlYT1e yDP0p8wAmOL/TcaLg32uBJFdZTn7tWe8PR5xNYjJ+B3J6emo7glJ0gq+pyY27z7ZrW RsCXOpUAqjEEHyM/3gJpHfkTqWPKNwTSH7U1jcB0= Message-ID: <3e4a8a44-483b-457a-b193-4119e4adfa85@linux.microsoft.com> Date: Wed, 29 Jan 2025 09:12:53 -0800 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Andrew Morton , Yaron Avizrat , Oded Gabbay , Julia Lawall , Nicolas Palix , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Jaroslav Kysela , Takashi Iwai , Chris Mason , Josef Bacik , David Sterba , Ilya Dryomov , Dongsheng Yang , Jens Axboe , Xiubo Li , Damien Le Moal , Niklas Cassel , Carlos Maiolino , "Darrick J. Wong" , Sebastian Reichel , Keith Busch , Sagi Grimberg , Frank Li , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shyam Sundar S K , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Henrique de Moraes Holschuh , Selvin Xavier , Kalesh AP , Jason Gunthorpe , Leon Romanovsky , cocci@inria.fr, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org Subject: Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies() To: Christoph Hellwig References: <20250128-converge-secs-to-jiffies-part-two-v1-0-9a6ecf0b2308@linux.microsoft.com> <20250128-converge-secs-to-jiffies-part-two-v1-9-9a6ecf0b2308@linux.microsoft.com> <20250129052108.GB28513@lst.de> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <20250129052108.GB28513@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/28/2025 9:21 PM, Christoph Hellwig wrote: > On Tue, Jan 28, 2025 at 06:21:54PM +0000, Easwar Hariharan wrote: >> else >> - cfg->retry_timeout = msecs_to_jiffies( >> - init[i].retry_timeout * MSEC_PER_SEC); >> + cfg->retry_timeout = secs_to_jiffies(init[i].retry_timeout); > > This messes up the formatting by introducing an overly long line. > > Otherwise the change looks fine. I'll fix this in v2. Thanks for the review! - Easwar (he/him)