From: Eric Sandeen <sandeen@redhat.com>
To: Ryosuke Yasuoka <ryasuoka@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Use for_each_perag() to iterate all available AGs
Date: Fri, 7 Apr 2023 08:24:12 -0500 [thread overview]
Message-ID: <3eaa1264-2ab4-fd1d-8871-47c2414cbc29@redhat.com> (raw)
In-Reply-To: <CAHpthZrcegPXhti5tDdb=_nwafWnU-FXmtc6aRU7juowMpOnUQ@mail.gmail.com>
On 4/6/23 11:03 AM, Ryosuke Yasuoka wrote:
> Eric,
>
> I failed to reply to you since I got some mistakes.
> Let me re-send my reply just in case.
>
> Thank you for reviewing my requests.
>
>> Can you explain what goes wrong if it is zero? Is there a test for this?
>>
>> If it's a general problem, what if the other 2 callers pass in the variable
>> start_agno with a value of 0?
> Sorry I couldn't prepare any tests to confirm what happens if it is zero
> because it is a kind of general problem.
>
> IIUC, passing zero to for_each_perag_wrap() is not problematic.
...
> OTOH, since we have already a for_each_perag() macro, which just iterates all AG
> from 0 and doesn't wrap, I think it is simpler to use for_earch_perag().
>
> Regards,
> Ryosuke
Ok - I couldn't tell from the original email if this was a bugfix or a
cleanup, and wanted to be sure.
Thanks!
-Eric
next prev parent reply other threads:[~2023-04-07 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 8:47 [PATCH] xfs: Use for_each_perag() to iterate all available AGs Ryosuke Yasuoka
2023-04-04 14:19 ` Eric Sandeen
2023-04-06 16:03 ` Ryosuke Yasuoka
2023-04-07 13:24 ` Eric Sandeen [this message]
2023-04-05 1:04 ` Dave Chinner
[not found] ` <CAHpthZoWRWS2bXFDQrB+iOz7AA_ZLGJKmytHjN582VaWQ_TRwg@mail.gmail.com>
2023-04-05 23:04 ` Dave Chinner
2023-04-07 9:06 ` Ryosuke Yasuoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eaa1264-2ab4-fd1d-8871-47c2414cbc29@redhat.com \
--to=sandeen@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ryasuoka@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox