* [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc
@ 2016-10-17 13:54 Eric Sandeen
2016-10-17 15:03 ` Bill O'Donnell
2016-10-17 21:36 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2016-10-17 13:54 UTC (permalink / raw)
To: linux-xfs
The commit:
f65306ea xfs: map an inode's offset to an exact physical block
added a pointless error0: target; remove it.
Addresses-Coverity-Id: 1373865
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index c27344c..861cf8d 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -3974,9 +3974,6 @@ xfs_bmap_remap_alloc(
* allocating, so skip that check by pretending to be freeing.
*/
error = xfs_alloc_fix_freelist(&args, XFS_ALLOC_FLAG_FREEING);
- if (error)
- goto error0;
-error0:
xfs_perag_put(args.pag);
if (error)
trace_xfs_bmap_remap_alloc_error(ap->ip, error, _RET_IP_);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc
2016-10-17 13:54 [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc Eric Sandeen
@ 2016-10-17 15:03 ` Bill O'Donnell
2016-10-17 21:36 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2016-10-17 15:03 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Mon, Oct 17, 2016 at 08:54:25AM -0500, Eric Sandeen wrote:
> The commit:
>
> f65306ea xfs: map an inode's offset to an exact physical block
>
> added a pointless error0: target; remove it.
>
> Addresses-Coverity-Id: 1373865
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index c27344c..861cf8d 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3974,9 +3974,6 @@ xfs_bmap_remap_alloc(
> * allocating, so skip that check by pretending to be freeing.
> */
> error = xfs_alloc_fix_freelist(&args, XFS_ALLOC_FLAG_FREEING);
> - if (error)
> - goto error0;
> -error0:
> xfs_perag_put(args.pag);
> if (error)
> trace_xfs_bmap_remap_alloc_error(ap->ip, error, _RET_IP_);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc
2016-10-17 13:54 [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc Eric Sandeen
2016-10-17 15:03 ` Bill O'Donnell
@ 2016-10-17 21:36 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2016-10-17 21:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Mon, Oct 17, 2016 at 08:54:25AM -0500, Eric Sandeen wrote:
> The commit:
>
> f65306ea xfs: map an inode's offset to an exact physical block
>
> added a pointless error0: target; remove it.
>
> Addresses-Coverity-Id: 1373865
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index c27344c..861cf8d 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3974,9 +3974,6 @@ xfs_bmap_remap_alloc(
> * allocating, so skip that check by pretending to be freeing.
> */
> error = xfs_alloc_fix_freelist(&args, XFS_ALLOC_FLAG_FREEING);
> - if (error)
> - goto error0;
> -error0:
> xfs_perag_put(args.pag);
> if (error)
> trace_xfs_bmap_remap_alloc_error(ap->ip, error, _RET_IP_);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-17 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 13:54 [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc Eric Sandeen
2016-10-17 15:03 ` Bill O'Donnell
2016-10-17 21:36 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).