Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime

Jeff Layton
2023-04-25T19:12:40Z

On Tue, 2023-04-25 at 18:56 +0100, Matthew Wilcox wrote:
> On Tue, Apr 25, 2023 at 01:45:19PM -0400, Jeff Layton wrote:
> > Erm...it may be an unpopular opinion, but I find that more confusing
> > than just ensuring that the s_time_gran > 1. I keep wondering if we
> > might want to carve out other low-order bits too for some later purpose,
> > at which point trying to check this using flags wouldn't work right. I
> > think I might just stick with what I have here, at least for now.
>
> But what if I set s_time_gran to 3 or 5? You'd really want a warning
> about that.

Ugh, I hadn't considered that. I don't see anyone that sets an odd
s_time_gran that isn't 1, but OK, good point. I'll change it.
--
Jeff Layton <jlayton@kernel.org>