From: Jens Axboe <axboe@kernel.dk>
To: Bob Liu <bob.liu@oracle.com>, linux-block@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
martin.petersen@oracle.com, shirley.ma@oracle.com,
allison.henderson@oracle.com, david@fromorbit.com,
darrick.wong@oracle.com, hch@infradead.org, adilger@dilger.ca,
tytso@mit.edu
Subject: Re: [PATCH v3 2/3] block: verify data when endio
Date: Fri, 29 Mar 2019 08:28:23 -0600 [thread overview]
Message-ID: <41c8688a-65bd-96ac-9b23-4facd0ade4a7@kernel.dk> (raw)
In-Reply-To: <20190329142346.1677-3-bob.liu@oracle.com>
On 3/29/19 8:23 AM, Bob Liu wrote:
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index d66bf5f32610..e9f25f162138 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -18,6 +18,7 @@ struct block_device;
> struct io_context;
> struct cgroup_subsys_state;
> typedef void (bio_end_io_t) (struct bio *);
> +typedef int (bio_verifier_t) (struct bio *);
>
> /*
> * Block error status values. See block/blk-core:blk_errors for the details.
> @@ -187,6 +188,8 @@ struct bio {
> struct bio_integrity_payload *bi_integrity; /* data integrity */
> #endif
> };
> + bio_verifier_t *bi_verifier; /* verify callback when endio */
> + struct work_struct bi_work; /* I/O completion */
>
> unsigned short bi_vcnt; /* how many bio_vec's */
I told you this for the initial posting, and the objection still stands.
Adding 40 bytes to struct bio is a no-go.
So that's a big NAK on that series.
--
Jens Axboe
next prev parent reply other threads:[~2019-03-29 14:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 14:23 [RFC PATCH v3 0/3] Block/XFS: Support alternative mirror device retry Bob Liu
2019-03-29 14:23 ` [PATCH v3 1/3] block: introduce submit_bio_verify() Bob Liu
2019-03-29 22:22 ` Andreas Dilger
2019-03-30 1:43 ` Martin K. Petersen
2019-03-29 14:23 ` [PATCH v3 2/3] block: verify data when endio Bob Liu
2019-03-29 14:28 ` Jens Axboe [this message]
2019-03-29 14:34 ` Martin K. Petersen
2019-03-29 14:38 ` Jens Axboe
2019-03-29 14:46 ` Martin K. Petersen
2019-03-29 14:50 ` Jens Axboe
2019-03-29 14:51 ` Martin K. Petersen
2019-03-29 14:52 ` Jens Axboe
2019-03-29 15:00 ` Bob Liu
2019-03-29 15:03 ` Jens Axboe
2019-03-30 2:17 ` Martin K. Petersen
2019-03-31 22:00 ` Dave Chinner
2019-04-01 14:04 ` Martin K. Petersen
2019-04-01 21:21 ` Dave Chinner
2019-04-03 2:45 ` Martin K. Petersen
2019-04-03 22:21 ` Dave Chinner
2019-03-29 14:41 ` Bob Liu
2019-03-29 14:40 ` Bob Liu
2019-03-29 14:47 ` Jens Axboe
2019-03-30 0:20 ` Andreas Dilger
2019-03-29 15:39 ` Ming Lei
2019-03-29 14:23 ` [PATCH v3 3/3] fs: xfs: add read_verifier() function Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41c8688a-65bd-96ac-9b23-4facd0ade4a7@kernel.dk \
--to=axboe@kernel.dk \
--cc=adilger@dilger.ca \
--cc=allison.henderson@oracle.com \
--cc=bob.liu@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shirley.ma@oracle.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).