From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f195.google.com ([209.85.166.195]:52378 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728737AbfC2O20 (ORCPT ); Fri, 29 Mar 2019 10:28:26 -0400 Received: by mail-it1-f195.google.com with SMTP id g17so3987703ita.2 for ; Fri, 29 Mar 2019 07:28:25 -0700 (PDT) Subject: Re: [PATCH v3 2/3] block: verify data when endio References: <20190329142346.1677-1-bob.liu@oracle.com> <20190329142346.1677-3-bob.liu@oracle.com> From: Jens Axboe Message-ID: <41c8688a-65bd-96ac-9b23-4facd0ade4a7@kernel.dk> Date: Fri, 29 Mar 2019 08:28:23 -0600 MIME-Version: 1.0 In-Reply-To: <20190329142346.1677-3-bob.liu@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Bob Liu , linux-block@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, martin.petersen@oracle.com, shirley.ma@oracle.com, allison.henderson@oracle.com, david@fromorbit.com, darrick.wong@oracle.com, hch@infradead.org, adilger@dilger.ca, tytso@mit.edu On 3/29/19 8:23 AM, Bob Liu wrote: > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index d66bf5f32610..e9f25f162138 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -18,6 +18,7 @@ struct block_device; > struct io_context; > struct cgroup_subsys_state; > typedef void (bio_end_io_t) (struct bio *); > +typedef int (bio_verifier_t) (struct bio *); > > /* > * Block error status values. See block/blk-core:blk_errors for the details. > @@ -187,6 +188,8 @@ struct bio { > struct bio_integrity_payload *bi_integrity; /* data integrity */ > #endif > }; > + bio_verifier_t *bi_verifier; /* verify callback when endio */ > + struct work_struct bi_work; /* I/O completion */ > > unsigned short bi_vcnt; /* how many bio_vec's */ I told you this for the initial posting, and the objection still stands. Adding 40 bytes to struct bio is a no-go. So that's a big NAK on that series. -- Jens Axboe