Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Wang Yugui <wangyugui@e16-tech.com>, linux-xfs@vger.kernel.org
Subject: Re: struct xfs_zone_scratch is undefined in 7.0-rc1
Date: Wed, 25 Feb 2026 18:01:59 +0900	[thread overview]
Message-ID: <42a5498b-31dc-4ad9-aa76-3d332d6113bc@kernel.org> (raw)
In-Reply-To: <20260225153923.47B2.409509F4@e16-tech.com>

On 2/25/26 16:39, Wang Yugui wrote:
> Hi,
> 
> struct xfs_zone_scratch is undefined in 7.0-rc1.
> 
> # grep xfs_zone_scratch -nr *
> fs/xfs/xfs_zone_gc.c:99:        struct xfs_zone_scratch         *scratch;
> #
> 
> Could we change 'struct xfs_zone_scratch  *' to 'void *',
> or just delete this var?

This should do it:

diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
index 48c6cf584447..d78e29cdcc45 100644
--- a/fs/xfs/xfs_zone_gc.c
+++ b/fs/xfs/xfs_zone_gc.c
@@ -96,7 +96,6 @@ struct xfs_gc_bio {
         */
        xfs_fsblock_t                   old_startblock;
        xfs_daddr_t                     new_daddr;
-       struct xfs_zone_scratch         *scratch;

        /* Are we writing to a sequential write required zone? */
        bool                            is_seq;
@@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
        ihold(VFS_I(chunk->ip));
        split_chunk->ip = chunk->ip;
        split_chunk->is_seq = chunk->is_seq;
-       split_chunk->scratch = chunk->scratch;
        split_chunk->offset = chunk->offset;
        split_chunk->len = split_len;
        split_chunk->old_startblock = chunk->old_startblock;

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-02-25  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  7:39 struct xfs_zone_scratch is undefined in 7.0-rc1 Wang Yugui
2026-02-25  9:01 ` Damien Le Moal [this message]
2026-02-25 14:08   ` Christoph Hellwig
2026-02-25 23:29     ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42a5498b-31dc-4ad9-aa76-3d332d6113bc@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=wangyugui@e16-tech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox