From: Pankaj Raghav <pankaj.raghav@linux.dev>
To: Christoph Hellwig <hch@infradead.org>,
Pankaj Raghav <p.raghav@samsung.com>
Cc: linux-xfs@vger.kernel.org, bfoster@redhat.com, lukas@herbolt.com,
"Darrick J . Wong" <djwong@kernel.org>,
dgc@kernel.org, gost.dev@samsung.com, andres@anarazel.de,
kundan.kumar@samsung.com, cem@kernel.org
Subject: Re: [PATCH v3 3/3] xfs: add a sysfs entry to enable write zeroes even if HW does not support it
Date: Sun, 26 Apr 2026 08:28:42 +0200 [thread overview]
Message-ID: <4315ac3f-cf0b-484b-a925-0e539a1bfff2@linux.dev> (raw)
In-Reply-To: <aet1u528eM5jQyCG@infradead.org>
On 4/24/26 15:52, Christoph Hellwig wrote:
> On Mon, Apr 20, 2026 at 12:55:39PM +0200, Pankaj Raghav wrote:
>> From: Lukas Herbolt <lukas@herbolt.com>
>>
>> Add a xfs sysfs entry that will not return ENOTSUPP for
>> FALLOC_FL_WRITE_ZEROES flag in fallocate even if the hardware does not
>> support deallocate on write zeroes. This is useful for testing this
>> feature independent of the HW underneath.
>
> I don't think it is. We can easily test this using a loop or scsi_debug
> device. And in fact should by adding an xfstests that uses such
> synthetic devices.
>
This makes sense. Also this avoids adding hardware specific knobs in the filesystem.
--
Pankaj
prev parent reply other threads:[~2026-04-26 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 10:55 [PATCH v3 0/3] add FALLOC_FL_WRITE_ZEROES support to xfs Pankaj Raghav
2026-04-20 10:55 ` [PATCH v3 1/3] xfs: add xfs_bmap_alloc_or_convert_range function Pankaj Raghav
2026-04-24 13:52 ` Christoph Hellwig
2026-04-26 6:35 ` Pankaj Raghav
2026-04-20 10:55 ` [PATCH v3 2/3] xfs: add support for FALLOC_FL_WRITE_ZEROES Pankaj Raghav
2026-04-20 10:55 ` [PATCH v3 3/3] xfs: add a sysfs entry to enable write zeroes even if HW does not support it Pankaj Raghav
2026-04-24 13:52 ` Christoph Hellwig
2026-04-26 6:28 ` Pankaj Raghav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4315ac3f-cf0b-484b-a925-0e539a1bfff2@linux.dev \
--to=pankaj.raghav@linux.dev \
--cc=andres@anarazel.de \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=kundan.kumar@samsung.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox