Re: review: fix bulkstat error detection logic

[Timothy Shimmin <tes@sgi.com>]

Nathan Scott wrote:
> Hi,
> 
> An earlier patch to remove bulkstat verbosity in debug kernels
> changed the xfs_itobp logic slightly, such that we no longer do
> the first stage of buffer checking there.  Turns out this isn't
> the right fix, we need to do that check still, and pass out the
> error code to bulkstat still, otherwise we either trip up logic
> in later debug code, or pass out success incorrectly.
> 
> This fixes that up, and is the last bulkstat change I have for
> awhile. :)  Its error handling is correct once more, its a fair
> bit quicker, and no more debug-kernel console spam - hooray!
> 
> cheers.
> 

Looks reasonable.
So you still do the inode buffer validation but we don't print out
a corruption error msg and we return EINVAL instead of EFSCORRUPTED.
Can we not be bulkstat'ing over inodes with reasonable numbers/locations but
the inode data on disk is just corrupted?
(I missed looking at the original patch)

(Interesting how previously you set ni to 0 in the XFS_IMAP_BULKSTAT
case and yet in the loop which would then never iterate (0<0=F),
you test for XFS_IMAP_BULKSTAT :)

--Tim