Re: review: Simple patch to remove the dmapi support from xfsdump

Bill Kendall
2006-08-04T16:46:31Z

Dean Roehrich wrote:
> On Fri, Aug 04, 2006 at 10:36:37AM -0500, Russell Cattelan wrote:
>
>
>>I appears as if the Hsm routines are only used if the -a flag is given
>>to xfsdump.
>>(dump DMF dualstate files as offline)
>
>
> If use of -a causes xfsdump to fail then that may be sufficient.

Then what? Each user (admittedly, this is a small number) has to rebuild
xfsdump locally, and then do so every time their package manager grabs
an updated xfsdump? That sounds like more of an inconvenience than
installing a couple packages on a build machine, especially considering
the xfsdump and libdm source are bundled together with all the other xfs
user space tools. (And isn't there logic in the xfs makefiles to use
the locally built libraries if the required libraries aren't installed?)

>
> Also, use of -D should cause xfsrestore to fail.

That's not necessary - there are no libdm calls in xfsrestore,
regardless of whether or not the image being restore came from
xfsdump -a.

There are several solutions here:

1) Russell's proposal -- noop hsm routines if libdm doesn't exist on
build machine.

2) Require libdm on build machine, change xfsdump to dlopen libdm so
that libdm is optional at run-time.

3) Add make_handle() routine to libhandle. xfsdump's only dependencies
from libdm are dm_make_handle() and dm_handle_to_fsid() (the latter
of which is in libhandle as handle_to_fshandle(), I think).

4) Noop the existing hsm routines, and allow xfsdump to dlopen a
specified .so to override the default (noop) behavior. DMF could
then ship a .so implementing those functions.

Bill